You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/05 17:28:35 UTC

[GitHub] [druid] vogievetsky opened a new pull request #11204: Web console: fix SegmentTimeline query

vogievetsky opened a new pull request #11204:
URL: https://github.com/apache/druid/pull/11204


   Fix the issue that the segment timeline was showing unpublished and overshadowed segments.
   Adds a filter of `is_published = 1 AND is_overshadowed = 0` to the SQL query.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on pull request #11204: Web console: fix SegmentTimeline query

Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11204:
URL: https://github.com/apache/druid/pull/11204#issuecomment-832939782


   @vogievetsky can we add a test to surface these types of issues in the web console?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #11204: Web console: fix SegmentTimeline query

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11204:
URL: https://github.com/apache/druid/pull/11204#issuecomment-833674916


   I added a unit test around the query
   
   ![image](https://user-images.githubusercontent.com/177816/117334692-29b04780-ae4f-11eb-9768-37ae6b2cf0e8.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #11204: Web console: fix SegmentTimeline query

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11204:
URL: https://github.com/apache/druid/pull/11204#issuecomment-833290005


   I am not sure how to test this effectively given the current test harness. I guess we would want and e2e test that loads a datasource with overshadowed and un-published segments and makes sure all the numbers are correct? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis merged pull request #11204: Web console: fix SegmentTimeline query

Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11204:
URL: https://github.com/apache/druid/pull/11204


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on pull request #11204: Web console: fix SegmentTimeline query

Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11204:
URL: https://github.com/apache/druid/pull/11204#issuecomment-833676691


   > I guess we would want and e2e test that loads a datasource with overshadowed and un-published segments and makes sure all the numbers are correct?
   
   This sounds like a good idea to me. Could you create a github issue to keep track of the testing needs so we can add more complete end to end tests like the one you suggested in the future.
   
   Thanks for the fix and the unit test :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org