You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/22 13:24:31 UTC

[GitHub] [hudi] yanghua commented on a diff in pull request #5930: [MINOR] Disable flaky clean test for bootstrap file only

yanghua commented on code in PR #5930:
URL: https://github.com/apache/hudi/pull/5930#discussion_r903738809


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestCleanPlanExecutor.java:
##########
@@ -273,7 +273,7 @@ public void testKeepLatestCommits(
    * Test Hudi COW Table Cleaner - Keep the latest file versions policy.
    */
   @ParameterizedTest
-  @ValueSource(booleans = {false, true})
+  @ValueSource(booleans = {false})

Review Comment:
   IMO, we at least leave a reason description(or a piece of todo information) for this action so that we could enable it in the future.
   It is about the test coverage.
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org