You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stephen More (JIRA)" <de...@myfaces.apache.org> on 2007/09/17 22:25:43 UTC
[jira] Created: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Adding Tiles2 support to tomahawk
---------------------------------
Key: TOMAHAWK-1115
URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
Project: MyFaces Tomahawk
Issue Type: Improvement
Components: Tiles
Reporter: Stephen More
Priority: Minor
It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TOMAHAWK-1115) Adding Tiles2 support
to tomahawk
Posted by "Navid Mitchell (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538637 ]
navidmitchell edited comment on TOMAHAWK-1115 at 10/29/07 4:59 PM:
--------------------------------------------------------------------
Antonio Petrelli on the Nabble forum asked me to post this here. I hope it Helps.
I was able to use the TilesViewHandler I just attached to use Tiles 2 with Tomahawk and Struts 2. The view handler requires that you have Tiles2 Setup in your Web XML. It should work fine with a standalone Tiles 2 JSF instalation. The view handler is a modified version of the Shale-Tiles view handler.
Also you will need to adjust line 100 of the TilesViewHandler source to reference the attached bundle.
Happy coding,
Navid Mitchell
was (Author: navidmitchell):
Antonio Petrelli on the Nabble forum asked me to post this here. I hope it Helps.
I was able to use the ViewHandler I just attached to use Tiles 2 with Tomahawk and Struts 2. The view handler requires that you have Tiles2 Setup in your Web XML. It should work fine with a standalone Tiles 2 JSF instalation. The view handler is a modified version of the Shale-Tiles view handler.
Happy coding,
Navid Mitchell
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
> Attachments: Bundle.properties, JspTiles2ViewHandlerImpl.java, TilesViewHandler.java
>
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528286 ]
Matthias Weßendorf commented on TOMAHAWK-1115:
----------------------------------------------
yes, that's right. Currently there is support for the "old" Tiles Framework.
Providing a patch to add Tiles 2 support would speed that up ;-)
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Navid Mitchell (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538637 ]
Navid Mitchell commented on TOMAHAWK-1115:
------------------------------------------
Antonio Petrelli on the Nabble forum asked me to post this here. I hope it Helps.
I was able to use the ViewHandler I just attached to use Tiles 2 with Tomahawk and Struts 2. The view handler requires that you have Tiles2 Setup in your Web XML. It should work fine with a standalone Tiles 2 JSF instalation. The view handler is a modified version of the Shale-Tiles view handler.
Happy coding,
Navid Mitchell
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
> Attachments: JspTiles2ViewHandlerImpl.java
>
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Stephen More (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen More updated TOMAHAWK-1115:
-----------------------------------
Status: Patch Available (was: Open)
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528497 ]
Matthias Weßendorf commented on TOMAHAWK-1115:
----------------------------------------------
cool.
what is the pom.xml change (patch) for tomahawk to have tiles2 support ?
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
> Attachments: JspTiles2ViewHandlerImpl.java
>
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538808 ]
Andrew Robinson commented on TOMAHAWK-1115:
-------------------------------------------
There has been resistance to including facelets support into Tomahawk core. For that reason I think Tiles2 should be applied under the same rules. We should either allow Facelets and other 3rd party dependencies into Tomahawk or allow none.
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
> Attachments: Bundle.properties, JspTiles2ViewHandlerImpl.java, TilesViewHandler.java
>
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Stephen More (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528509 ]
Stephen More commented on TOMAHAWK-1115:
----------------------------------------
$ svn diff pom.xml
Index: pom.xml
===================================================================
--- pom.xml (revision 576474)
+++ pom.xml (working copy)
@@ -60,6 +60,22 @@
</dependency>
<dependency>
+ <groupId>org.apache.tiles</groupId>
+ <artifactId>tiles-core</artifactId>
+ <version>2.0.4</version>
+ <scope>compile</scope>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.tiles</groupId>
+ <artifactId>tiles-jsp</artifactId>
+ <version>2.0.4</version>
+ <scope>compile</scope>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
<groupId>commons-el</groupId>
<artifactId>commons-el</artifactId>
<version>1.0</version>
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
> Attachments: JspTiles2ViewHandlerImpl.java
>
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538835 ]
Mike Kienenberger commented on TOMAHAWK-1115:
---------------------------------------------
The resistance was due to the lack of code generation, not due to 3rd party dependencies.
Although I think that Facelets has special case dependency issues since it requires (last time I looked) JSF 1.2 to compile and some Facelets tag handlers inherit from JSF 1.2 classes? I could be mistaken, though.
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
> Attachments: Bundle.properties, JspTiles2ViewHandlerImpl.java, TilesViewHandler.java
>
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Navid Mitchell (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539030 ]
Navid Mitchell commented on TOMAHAWK-1115:
------------------------------------------
I agree with Andrew. I think it is bad form to make Tomahawk dependent on any templating technology. I am however using Tiles and Faclets with Tomahawk in two separate projects. I think it would be better to provide a separate set of jars that allow the configuration of either without changing the core of Tomahawk. This can already be accomplished in either case by changing the View Handler in the faces-config. I posted the view handler here with hopes it may save someone the time of making their own. It was a real pain in the butt to get Tiles 2 working at first. Mike it does look like JSF 1.2 is required to build facelets. However you can use it without JSF 1.2 if you are using MyFaces. https://facelets.dev.java.net/nonav/docs/dev/docbook.html#gettingstarted-dependencies
Anyways that is just my two cents.
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Priority: Minor
> Attachments: Bundle.properties, JspTiles2ViewHandlerImpl.java, TilesViewHandler.java
>
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1115) Adding Tiles2 support to tomahawk
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Marinschek updated TOMAHAWK-1115:
----------------------------------------
Resolution: Duplicate
Fix Version/s: 1.1.7-SNAPSHOT
Assignee: Martin Marinschek
Status: Resolved (was: Patch Available)
Duplicate of TOMAHAWK-1160. Actually, TOMAHAWK-1160 is the duplicate. Forgive my ignorance - my only excuse is that my solution is cleaner, and also works in a portlet environment.
regards,
Martin
> Adding Tiles2 support to tomahawk
> ---------------------------------
>
> Key: TOMAHAWK-1115
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1115
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Tiles
> Reporter: Stephen More
> Assignee: Martin Marinschek
> Priority: Minor
> Fix For: 1.1.7-SNAPSHOT
>
> Attachments: Bundle.properties, JspTiles2ViewHandlerImpl.java, TilesViewHandler.java
>
>
> It looks like branch 1.x of struts is supported. ( http://myfaces.apache.org/tomahawk/tiles.html )
> Can code be added to support tiles 2 ( http://tiles.apache.org/ ) ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.