You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Lindsey Zurovchak (Jira)" <ji...@apache.org> on 2022/12/22 18:43:00 UTC
[jira] [Commented] (CASSANDRA-16418) Unsafe to run nodetool cleanup during bootstrap or decommission
[ https://issues.apache.org/jira/browse/CASSANDRA-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651377#comment-17651377 ]
Lindsey Zurovchak commented on CASSANDRA-16418:
-----------------------------------------------
Created [PR|https://github.com/apache/cassandra/pull/2061] for this and made the following changes:
* Added check during cleanup to ensure the node has no pending ranges before proceeding
* Bug did not exist for bootstrap due to existing safety check but the check was one level below other safeguard checks so moved it to same location
> Unsafe to run nodetool cleanup during bootstrap or decommission
> ---------------------------------------------------------------
>
> Key: CASSANDRA-16418
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16418
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Bootstrap and Decommission
> Reporter: James Baker
> Assignee: Lindsey Zurovchak
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> What we expected: Running a cleanup is a safe operation; the result of running a query after a cleanup should be the same as the result of running a query before a cleanup.
> What actually happened: We ran a cleanup during a decommission. All the streamed data was silently deleted, the bootstrap did not fail, the cluster's data after the decommission was very different to the state before.
> Why: Cleanups do not take into account pending ranges and so the cleanup thought that all the data that had just been streamed was redundant and so deleted it. We think that this is symmetric with bootstraps, though have not verified.
> Not sure if this is technically a bug but it was very surprising (and seemingly undocumented) behaviour.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org