[GitHub] [hbase] bharathv commented on a change in pull request #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible…

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible…
URL: https://github.com/apache/hbase/pull/1047#discussion_r366994096
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
 ##########
 @@ -133,12 +152,12 @@ public void init(Context context) throws IOException {
     // TODO: This connection is replication specific or we should make it particular to
     // replication and make replication specific settings such as compression or codec to use
     // passing Cells.
-    this.conn = (ClusterConnection) ConnectionFactory.createConnection(this.conf);
+    this.conn = (ClusterConnection) createConnection(this.conf);
 
 Review comment:
   Do we need force createConnection() to return a connection of type ClusterConnection? Otherwise, theoretically overrides can return any type of Connection (may or may not be ClusterConnection) and the type cast here fails. Just a thought.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services