You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/03/27 19:18:02 UTC
[GitHub] [lucene-solr] zacharymorn opened a new pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel
zacharymorn opened a new pull request #2471:
URL: https://github.com/apache/lucene-solr/pull/2471
This PR backports changes from https://github.com/apache/lucene/pull/25 into Lucene 8x
I have run `ant clean; ant precommit; ant test` to validate the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #2471:
URL: https://github.com/apache/lucene-solr/pull/2471#issuecomment-809541741
Aha, thank you @zacharymorn! I'll have a look.
Out of curiosity: were you able to use git somehow to cherry-pick across the repositories/branches? Or did you diff/patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand merged pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel
Posted by GitBox <gi...@apache.org>.
mikemccand merged pull request #2471:
URL: https://github.com/apache/lucene-solr/pull/2471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #2471:
URL: https://github.com/apache/lucene-solr/pull/2471#issuecomment-809541919
Also, were there any conflicts you had to resolve manually? Or it was smooth sailing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] zacharymorn commented on pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel
Posted by GitBox <gi...@apache.org>.
zacharymorn commented on pull request #2471:
URL: https://github.com/apache/lucene-solr/pull/2471#issuecomment-809872761
HI @mikemccand , thanks for approving and merging the changes! I researched around cross-repo cherry-picking and found that git seems to support it to some extend, but may still require manual conflict resolution effort. The steps / commands I ran inside the old lucene-solr repo on branch `branch_8x` are:
1. `git remote add lucene https://github.com/apache/lucene.git`
1. `git fetch lucene`
1. `git branch lucene_main lucene/main`
1. `git log lucene_main` # to get the commit hash
1. `git checkout -b branch_8x_backporting_LUCENE-9385_skip_drilldown`
1. `git cherry-pick -x 3648a1020a8ab`
At this point git showed me there was conflict for `FacetsConfig.java`, in basically all sections of code I had changed, so I had to resolve them manually. However, I noticed it did not report any conflict for new tests in the test classes, so I guess it can handle cross-repo addition fine, but may report on conflict for modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #2471:
URL: https://github.com/apache/lucene-solr/pull/2471#issuecomment-809607098
Thanks @zacharymorn!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org