You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/11/14 10:31:18 UTC
[PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
pitrou opened a new pull request, #38713:
URL: https://github.com/apache/arrow/pull/38713
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #38713:
URL: https://github.com/apache/arrow/pull/38713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz commented on code in PR #38713:
URL: https://github.com/apache/arrow/pull/38713#discussion_r1394320504
##########
python/pyarrow/src/arrow/python/common.h:
##########
@@ -235,6 +238,48 @@ class ARROW_PYTHON_EXPORT OwnedRefNoGIL : public OwnedRef {
}
};
+template <template <typename...> typename SmartPtr, typename... Ts>
+class SmartPtrNoGIL : public SmartPtr<Ts...> {
+ using Base = SmartPtr<Ts...>;
+
+ public:
+ template <typename... Args>
+ SmartPtrNoGIL(Args&&... args) : Base(std::forward<Args>(args)...) {}
+
+ ~SmartPtrNoGIL() { reset(); }
+
+ template <typename... Args>
+ void reset(Args&&... args) {
+ auto release_guard = optional_gil_release();
+ Base::reset(std::forward<Args>(args)...);
+ }
+
+ template <typename V>
+ SmartPtrNoGIL& operator=(V&& v) {
+ auto release_guard = optional_gil_release();
+ Base::operator=(std::forward<V>(v));
+ return *this;
+ }
+
+ private:
+ // Only release the GIL if we own an object *and* the Python runtime is
+ // valid *and* the GIL is held.
+ std::optional<PyReleaseGIL> optional_gil_release() const {
+ if (this->get() != nullptr && Py_IsInitialized() && PyGILState_Check()) {
+ return PyReleaseGIL();
+ }
+ return {};
+ }
+};
+
+/// \brief A std::shared_ptr<T, ...> subclass that releases the GIL when destroying T
+template <typename... Ts>
+using SharedPtrNoGIL = SmartPtrNoGIL<std::shared_ptr, Ts...>;
Review Comment:
What if the no GIL smart pointer wraps an object which must call into python as part of its destruction? (For example a dataset which wraps a python file system.) I *think* that this will be fine since such a call would acquire the GIL at the call site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38713:
URL: https://github.com/apache/arrow/pull/38713#issuecomment-1810194996
Revision: 01cbb5e3c9cb12f41ea7e3131a3a527aba184a29
Submitted crossbow builds: [ursacomputing/crossbow @ actions-296d519c27](https://github.com/ursacomputing/crossbow/branches/all?query=actions-296d519c27)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/6864203412/job/18665451501)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/6864218901/job/18665498972)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/6864216143/job/18665490670)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6864218425/job/18665497720)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6864209688/job/18665470548)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/6864222825/job/18665510453)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6864217661/job/18665495295)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/6864224197/job/18665515073)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6864206530/job/18665460789)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6864212949/job/18665479980)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6864205897/job/18665459296)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/6864225035/job/18665518119)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6864208823/job/18665467805)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/6864210359/job/18665472375)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/6864220833/job/18665504360)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/6864216548/job/18665491884)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6864223807/job/18665513523)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6864211980/job/18665477094)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/6864213419/job/18665481432)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6864214094/job/18665483359)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6864204580/job/18665455218)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/18665512748)|
|test-fedora-38-python-3|[](https://github.com/ursacomputing/crossbow/runs/18665505737)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/18665459000)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/6864215821/job/18665489381)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864211359/job/18665475389)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864207666/job/18665464539)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864205295/job/18665457557)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864203413/job/18665451458)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864204052/job/18665453297)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864207223/job/18665463187)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864224683/job/18665516853)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864207095/job/18665462848)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864210770/job/18665473499)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864216724/job/18665492480)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864227669/job/18665527482)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864214678/job/18665485411)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864225715/job/18665520832)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864225069/job/18665518238)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864208096/job/18665465676)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864226396/job/18665522979)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864225927/job/18665521641)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864226836/job/18665524522)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864227016/job/18665525091)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864220877/job/18665504557)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864209930/job/18665470958)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864221715/job/18665506919)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864214840/job/18665485912)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864222278/job/18665508486)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864218122/job/18665496632)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864215295/job/18665487681)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864227983/job/18665528366)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864209233/job/18665469076)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864223345/job/18665512060)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864219801/job/18665501587)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864217197/job/18665493991)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864219324/job/18665500188)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864214041/job/18665483088)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864205633/job/18665458446)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6864204362/job/18665454240)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #38713:
URL: https://github.com/apache/arrow/pull/38713#discussion_r1394326106
##########
python/pyarrow/src/arrow/python/common.h:
##########
@@ -235,6 +238,48 @@ class ARROW_PYTHON_EXPORT OwnedRefNoGIL : public OwnedRef {
}
};
+template <template <typename...> typename SmartPtr, typename... Ts>
+class SmartPtrNoGIL : public SmartPtr<Ts...> {
+ using Base = SmartPtr<Ts...>;
+
+ public:
+ template <typename... Args>
+ SmartPtrNoGIL(Args&&... args) : Base(std::forward<Args>(args)...) {}
+
+ ~SmartPtrNoGIL() { reset(); }
+
+ template <typename... Args>
+ void reset(Args&&... args) {
+ auto release_guard = optional_gil_release();
+ Base::reset(std::forward<Args>(args)...);
+ }
+
+ template <typename V>
+ SmartPtrNoGIL& operator=(V&& v) {
+ auto release_guard = optional_gil_release();
+ Base::operator=(std::forward<V>(v));
+ return *this;
+ }
+
+ private:
+ // Only release the GIL if we own an object *and* the Python runtime is
+ // valid *and* the GIL is held.
+ std::optional<PyReleaseGIL> optional_gil_release() const {
+ if (this->get() != nullptr && Py_IsInitialized() && PyGILState_Check()) {
+ return PyReleaseGIL();
+ }
+ return {};
+ }
+};
+
+/// \brief A std::shared_ptr<T, ...> subclass that releases the GIL when destroying T
+template <typename... Ts>
+using SharedPtrNoGIL = SmartPtrNoGIL<std::shared_ptr, Ts...>;
Review Comment:
> I _think_ that this will be fine since such a call would acquire the GIL at the call site
Yes, it would.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38713:
URL: https://github.com/apache/arrow/pull/38713#issuecomment-1809989748
@github-actions crossbow submit -g python -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38713:
URL: https://github.com/apache/arrow/pull/38713#issuecomment-1809996530
Revision: 6e89d22f9d33164edcf0af25af4615ebf0592855
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6a2251772a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6a2251772a)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/6862685960/job/18660927003)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/6862698401/job/18660965666)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/6862691187/job/18660941898)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6862685768/job/18660926588)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6862688430/job/18660933660)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/6862697811/job/18660964260)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6862692870/job/18660948839)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/6862688903/job/18660934801)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6862683130/job/18660917654)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6862703291/job/18660982002)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6862690659/job/18660940182)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/6862695960/job/18660959090)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6862696946/job/18660961902)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/6862693834/job/18660952903)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/6862682511/job/18660915003)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/6862686596/job/18660928819)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6862683021/job/18660917117)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6862684711/job/18660922972)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/6862694207/job/18660954219)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6862682138/job/18660913542)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6862683470/job/18660918872)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/18660952608)|
|test-fedora-38-python-3|[](https://github.com/ursacomputing/crossbow/runs/18660945203)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/18660965230)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/6862701050/job/18660974094)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862700093/job/18660970891)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862694819/job/18660955877)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862680126/job/18660907497)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862692341/job/18660946626)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862699714/job/18660969537)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862692065/job/18660945201)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862684964/job/18660923952)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862699232/job/18660968323)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862681252/job/18660910639)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862687419/job/18660931005)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862680949/job/18660909737)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862696383/job/18660960237)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862687991/job/18660932659)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862684252/job/18660921555)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862702937/job/18660981050)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862701874/job/18660977156)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862689444/job/18660936365)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862695159/job/18660956994)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862685248/job/18660924687)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862692610/job/18660947701)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862686573/job/18660928880)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862695666/job/18660958349)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862698868/job/18660967476)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862702540/job/18660979650)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862700560/job/18660972381)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862689665/job/18660937036)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862680423/job/18660908424)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862682627/job/18660915863)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862693575/job/18660951962)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862700806/job/18660973055)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862690642/job/18660940101)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862702205/job/18660978296)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862701701/job/18660976528)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862681619/job/18660912061)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/6862701489/job/18660975623)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38713:
URL: https://github.com/apache/arrow/pull/38713#issuecomment-1810188462
@github-actions crossbow submit -g python -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38676: [Python] Fix potential deadlock when CSV reading errors out [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38713:
URL: https://github.com/apache/arrow/pull/38713#issuecomment-1813038275
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit d076c69e81e5d331bae214a3cf9fabedb17752fa.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/18717590319) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org