You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/11 02:33:10 UTC
[GitHub] [incubator-dolphinscheduler] gabrywu opened a new issue #1929:
[BUG] checkOtherParams unreasonable logic
gabrywu opened a new issue #1929: [BUG] checkOtherParams unreasonable logic
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1929
The ProcessDefinitionService.checkProcessNodeList method has below codes:
`
for (TaskNode taskNode : taskNodes) {
if (!CheckUtils.checkTaskNodeParameters(taskNode.getParams(), taskNode.getType())) {
logger.error("task node {} parameter invalid", taskNode.getName());
putMsg(result, Status.PROCESS_NODE_S_PARAMETER_INVALID, taskNode.getName());
return result;
}
// check extra params
CheckUtils.checkOtherParams(taskNode.getExtras());
}
`
What's the meaning of 'CheckUtils.checkOtherParams'?
Should ‘CheckUtils.checkOtherParams’ throw an exception？
`
public static boolean checkTaskNodeParameters(String parameter, String taskType) {
AbstractParameters abstractParameters = TaskParametersUtils.getParameters(taskType, parameter);
if (abstractParameters != null) {
return abstractParameters.checkParameters();
}
return false;
}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] gabrywu edited a comment on issue
#1929: [BUG] checkOtherParams unreasonable logic
Posted by GitBox <gi...@apache.org>.
gabrywu edited a comment on issue #1929: [BUG] checkOtherParams unreasonable logic
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1929#issuecomment-612606999
>
>
> does this issue solved or not ?
reslove later, close this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] gabrywu closed issue #1929: [BUG]
checkOtherParams unreasonable logic
Posted by GitBox <gi...@apache.org>.
gabrywu closed issue #1929: [BUG] checkOtherParams unreasonable logic
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1929
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1929:
[BUG] checkOtherParams unreasonable logic
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1929: [BUG] checkOtherParams unreasonable logic
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1929#issuecomment-612551322
does this issue solved or not ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] gabrywu commented on issue #1929:
[BUG] checkOtherParams unreasonable logic
Posted by GitBox <gi...@apache.org>.
gabrywu commented on issue #1929: [BUG] checkOtherParams unreasonable logic
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1929#issuecomment-612606999
>
>
> does this issue solved or not ?
reslove later, close first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services