You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2017/02/28 05:32:02 UTC
Review Request 57124: Hive view 2.0 Fetch stats doesn't work when you
point against LLAP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57124/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Bugs: AMBARI-20223
https://issues.apache.org/jira/browse/AMBARI-20223
Repository: ambari
Description
-------
For fetching stats we are using old query syntax that wont work in Hive 2.0. Changed the query to newer syntax.
Diffs
-----
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java b119f6a
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java 73b3698
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 42cec0a
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java 3406b80
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java 35ea416
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy cce9e6c
Diff: https://reviews.apache.org/r/57124/diff/
Testing
-------
Manually Tested.
Thanks,
Gaurav Nagar
Re: Review Request 57124: Hive view 2.0 Fetch stats doesn't work when
you point against LLAP
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57124/#review167064
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 28, 2017, 5:32 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57124/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 5:32 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20223
> https://issues.apache.org/jira/browse/AMBARI-20223
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For fetching stats we are using old query syntax that wont work in Hive 2.0. Changed the query to newer syntax.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java b119f6a
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java 73b3698
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 42cec0a
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java 3406b80
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java 35ea416
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy cce9e6c
>
> Diff: https://reviews.apache.org/r/57124/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 57124: Hive view 2.0 Fetch stats doesn't work when
you point against LLAP
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57124/#review167124
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 28, 2017, 5:32 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57124/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 5:32 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20223
> https://issues.apache.org/jira/browse/AMBARI-20223
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For fetching stats we are using old query syntax that wont work in Hive 2.0. Changed the query to newer syntax.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java b119f6a
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java 73b3698
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 42cec0a
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java 3406b80
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java 35ea416
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy cce9e6c
>
> Diff: https://reviews.apache.org/r/57124/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
>
> Thanks,
>
> Gaurav Nagar
>
>
Re: Review Request 57124: Hive view 2.0 Fetch stats doesn't work when
you point against LLAP
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57124/#review167024
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Feb. 28, 2017, 5:32 a.m., Gaurav Nagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57124/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 5:32 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20223
> https://issues.apache.org/jira/browse/AMBARI-20223
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For fetching stats we are using old query syntax that wont work in Hive 2.0. Changed the query to newer syntax.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java b119f6a
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java 73b3698
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 42cec0a
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java 3406b80
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java 35ea416
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy cce9e6c
>
> Diff: https://reviews.apache.org/r/57124/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
>
> Thanks,
>
> Gaurav Nagar
>
>