You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/01/22 17:51:42 UTC

svn commit: r1437045 - /commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/X5455_ExtendedTimestampTest.java

Author: sebb
Date: Tue Jan 22 16:51:42 2013
New Revision: 1437045

URL: http://svn.apache.org/viewvc?rev=1437045&view=rev
Log:
Simplify and avoid a lot of boxing/unboxing warnings

Modified:
    commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/X5455_ExtendedTimestampTest.java

Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/X5455_ExtendedTimestampTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/X5455_ExtendedTimestampTest.java?rev=1437045&r1=1437044&r2=1437045&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/X5455_ExtendedTimestampTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/X5455_ExtendedTimestampTest.java Tue Jan 22 16:51:42 2013
@@ -396,18 +396,16 @@ public class X5455_ExtendedTimestampTest
             final byte[] expectedLocal,
             final byte[] almostExpectedCentral
     ) throws ZipException {
-        parseReparse(null, time, null, expectedLocal, almostExpectedCentral);
+        parseReparse(expectedLocal[0], time, expectedLocal[0], expectedLocal, almostExpectedCentral);
     }
 
     private void parseReparse(
-            final Byte providedFlagsByte,
+            final byte providedFlags,
             final ZipLong time,
-            final Byte expectedFlagsByte,
+            final byte expectedFlags,
             final byte[] expectedLocal,
             final byte[] almostExpectedCentral
     ) throws ZipException {
-        final byte providedFlags = providedFlagsByte == null ? expectedLocal[0] : providedFlagsByte;
-        final byte expectedFlags = expectedFlagsByte == null ? expectedLocal[0] : expectedFlagsByte;
 
         // We're responsible for expectedCentral's flags.  Too annoying to set in caller.
         final byte[] expectedCentral = new byte[almostExpectedCentral.length];