[GitHub] [openjpa] jgrassel edited a comment on pull request #64: [2.2.x] OPENJPA-2817: OpenJPA enhancer needs improved reentrancy

[GitBox <gi...@apache.org>]

jgrassel edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-657767799


   I asked Albert via company internal slack to review my changes, he's not set up a link between github and apache yet.
   
   ```
   Joe Grassel  11:07 AM
   Hey, Albert.  Hope things are going well!  I was going to ask if you could do an OpenJPA code review, as Will is out until tomorrow and I've got a customer pressuring for an ifix asap.  https://issues.apache.org/jira/browse/OPENJPA-2817
   
   Albert Lee  12:31 PM
   Jody,  I have reviewed the PR.  I don't have access to approve the PR.
   Once one comment:
   private static final ThreadLocal<Boolean> tl = new ThreadLocal();
   12:33
   you may want to add a comment for that this variable is for.   tl does not means anything to me.  The value in this ThreadLocal is irrelevant since you are just checking for not null. Change it to isTransformingInLocalThread ?
   
   Joe Grassel  12:33 PM
   Oh, sure, that's a good idea.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org