[GitHub] spark pull request #16165: [SPARK-8617] [WEBUI] HistoryServer: Include in-pr...

[ajbozarth <gi...@git.apache.org>]

Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16165#discussion_r91208762
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -546,7 +546,7 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
           val appsToRetain = new mutable.LinkedHashMap[String, FsApplicationHistoryInfo]()
     
           def shouldClean(attempt: FsApplicationAttemptInfo): Boolean = {
    -        now - attempt.lastUpdated > maxAge && attempt.completed
    +        now - attempt.lastUpdated > maxAge
    --- End diff --
    
    Nice catch @vanzin, I missed that, but (devil's advocate) should that level of granularity matter for something cleaning, which is measured in days?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org