[GitHub] [incubator-superset] etr2460 commented on a change in pull request #7950: Add dashboard loading indicator

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #7950: Add dashboard loading indicator
URL: https://github.com/apache/incubator-superset/pull/7950#discussion_r309436869
 
 

 ##########
 File path: superset/assets/src/dashboard/components/Header.jsx
 ##########
 @@ -314,6 +315,9 @@ class Header extends React.PureComponent {
               isStarred={this.props.isStarred}
             />
           </span>
+          <span className="dashboard-loading">
 
 Review comment:
   it might be cleaner to wrap the span with the boolean so it doesn't even render when it's not loading

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org