You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/08/15 13:17:06 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #1776][FOLLOWUP] Fill empty td tag for `Failure Reason` column in EngineTable
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new f60e9d471 [KYUUBI #1776][FOLLOWUP] Fill empty td tag for `Failure Reason` column in EngineTable
f60e9d471 is described below
commit f60e9d471dfc5f8ae83c5f1355fb262d4447fb1d
Author: Wang Zhen <wa...@qiyi.com>
AuthorDate: Mon Aug 15 21:16:54 2022 +0800
[KYUUBI #1776][FOLLOWUP] Fill empty td tag for `Failure Reason` column in EngineTable
### _Why are the changes needed?_
Followup #1776
'Failure Reason' column needs to be filled with empty td tag when there is no exception:
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [X] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #3223 from wForget/KYUUBI-1776-followup.
Closes #1776
a83d0007 [Wang Zhen] [KYUUBI-1776][FOLLOWUP] Fill empty td tag for `Failure Reason` column in EngineTable
Authored-by: Wang Zhen <wa...@qiyi.com>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.../src/main/scala/org/apache/spark/ui/EnginePage.scala | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EnginePage.scala b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EnginePage.scala
index 94316c91b..9e8cf96e4 100644
--- a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EnginePage.scala
+++ b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EnginePage.scala
@@ -388,7 +388,9 @@ private class StatementStatsPagedTable(
}
}
</td>
- {if (event.exception.isDefined) errorMessageCell(event.exception.get.getMessage)}
+ {
+ if (event.exception.isDefined) errorMessageCell(event.exception.get.getMessage) else <td></td>
+ }
</tr>
}