You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/08/05 18:16:37 UTC

Review Request 24317: Initial implementation of the UpdateStore (save events).

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24317/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.


Bugs: AURORA-612
    https://issues.apache.org/jira/browse/AURORA-612


Repository: aurora


Description
-------

Update store methods for saving job and instance update events.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 1d2e8951ce7c6cdde568d928fece5fce7e5fcb95 
  src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java e4adfe2e11753eb296a51b39426dee53827430ba 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 54d8362cb895ffa61ffc5b943e3c7faabc816bde 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 55efa966e3115968c616bd4e8b73631ee056a440 
  src/main/thrift/org/apache/aurora/gen/api.thrift 24b065dc12ede605d74229c5f30acb06ce12245e 
  src/main/thrift/org/apache/aurora/gen/storage.thrift 816086ed537696d6194a65f20456dc32d510608d 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java bef0ee70abf6a5d77ded65ba2aa581f97e26a851 

Diff: https://reviews.apache.org/r/24317/diff/


Testing
-------

gradle -Pq build


Thanks,

Maxim Khutornenko


Re: Review Request 24317: Initial implementation of the UpdateStore (save events).

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24317/#review49624
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Aug. 5, 2014, 9:16 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24317/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 9:16 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-612
>     https://issues.apache.org/jira/browse/AURORA-612
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update store methods for saving job and instance update events.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 1d2e8951ce7c6cdde568d928fece5fce7e5fcb95 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java e4adfe2e11753eb296a51b39426dee53827430ba 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 54d8362cb895ffa61ffc5b943e3c7faabc816bde 
>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 55efa966e3115968c616bd4e8b73631ee056a440 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 24b065dc12ede605d74229c5f30acb06ce12245e 
>   src/main/thrift/org/apache/aurora/gen/storage.thrift 816086ed537696d6194a65f20456dc32d510608d 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java bef0ee70abf6a5d77ded65ba2aa581f97e26a851 
> 
> Diff: https://reviews.apache.org/r/24317/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Re: Review Request 24317: Initial implementation of the UpdateStore (save events).

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24317/#review49618
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On Aug. 5, 2014, 4:16 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24317/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 4:16 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-612
>     https://issues.apache.org/jira/browse/AURORA-612
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update store methods for saving job and instance update events.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 1d2e8951ce7c6cdde568d928fece5fce7e5fcb95 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java e4adfe2e11753eb296a51b39426dee53827430ba 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 54d8362cb895ffa61ffc5b943e3c7faabc816bde 
>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 55efa966e3115968c616bd4e8b73631ee056a440 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 24b065dc12ede605d74229c5f30acb06ce12245e 
>   src/main/thrift/org/apache/aurora/gen/storage.thrift 816086ed537696d6194a65f20456dc32d510608d 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java bef0ee70abf6a5d77ded65ba2aa581f97e26a851 
> 
> Diff: https://reviews.apache.org/r/24317/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Re: Review Request 24317: Initial implementation of the UpdateStore (save events).

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24317/#review49614
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Aug. 5, 2014, 4:16 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24317/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 4:16 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-612
>     https://issues.apache.org/jira/browse/AURORA-612
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update store methods for saving job and instance update events.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 1d2e8951ce7c6cdde568d928fece5fce7e5fcb95 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java e4adfe2e11753eb296a51b39426dee53827430ba 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 54d8362cb895ffa61ffc5b943e3c7faabc816bde 
>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 55efa966e3115968c616bd4e8b73631ee056a440 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 24b065dc12ede605d74229c5f30acb06ce12245e 
>   src/main/thrift/org/apache/aurora/gen/storage.thrift 816086ed537696d6194a65f20456dc32d510608d 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java bef0ee70abf6a5d77ded65ba2aa581f97e26a851 
> 
> Diff: https://reviews.apache.org/r/24317/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>