You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/20 10:02:20 UTC

[GitHub] [airflow] ilyash-b opened a new issue #11679: airflow/example_dags/example_kubernetes_executor.py - use_zip_binary() - code quality issue

ilyash-b opened a new issue #11679:
URL: https://github.com/apache/airflow/issues/11679


   The description of `use_zip_binary()` is incorrect.
   
   https://github.com/apache/airflow/blob/318f18f5a835f457c6a68426a476af89ace0c7e7/airflow/example_dags/example_kubernetes_executor.py#L69-L70
   
   Additionally, the name `use_zip_binary` is not very telling. Maybe `assert_zip_binary` (based on what the function actually does)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #11679: airflow/example_dags/example_kubernetes_executor.py - use_zip_binary() - code quality issue

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #11679:
URL: https://github.com/apache/airflow/issues/11679#issuecomment-712740288


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ilyash-b commented on issue #11679: airflow/example_dags/example_kubernetes_executor.py - use_zip_binary() - code quality issue

Posted by GitBox <gi...@apache.org>.
ilyash-b commented on issue #11679:
URL: https://github.com/apache/airflow/issues/11679#issuecomment-712761775


   I just started looking at the project and I don't understand enough to fix it quickly. The name `use_zip_binary` is debatable so I would probably leave it as is. What I don't know for example is how `use_zip_binary()` is even supposed to behave.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ilyash-b edited a comment on issue #11679: airflow/example_dags/example_kubernetes_executor.py - use_zip_binary() - code quality issue

Posted by GitBox <gi...@apache.org>.
ilyash-b edited a comment on issue #11679:
URL: https://github.com/apache/airflow/issues/11679#issuecomment-712761775


   I just started looking at the project and I don't understand enough to fix it quickly. I don't know for example is how `use_zip_binary()` is even supposed to behave.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #11679: airflow/example_dags/example_kubernetes_executor.py - use_zip_binary() - code quality issue

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11679:
URL: https://github.com/apache/airflow/issues/11679#issuecomment-712758237


   Can you create PR with patch? I am happy to help with the review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb closed issue #11679: airflow/example_dags/example_kubernetes_executor.py - use_zip_binary() - code quality issue

Posted by GitBox <gi...@apache.org>.
ashb closed issue #11679:
URL: https://github.com/apache/airflow/issues/11679


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ilyash-b commented on issue #11679: airflow/example_dags/example_kubernetes_executor.py - use_zip_binary() - code quality issue

Posted by GitBox <gi...@apache.org>.
ilyash-b commented on issue #11679:
URL: https://github.com/apache/airflow/issues/11679#issuecomment-712763199


   Another thing. `The zip binary is missing` is semantically incorrect. Should be something like `Failed to run the zip binary`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ilyash-b commented on issue #11679: airflow/example_dags/example_kubernetes_executor.py - use_zip_binary() - code quality issue

Posted by GitBox <gi...@apache.org>.
ilyash-b commented on issue #11679:
URL: https://github.com/apache/airflow/issues/11679#issuecomment-712742165


   > issue template
   
   Oops. Found bug in GitHub then. When you select the code first and then reference in new issue (which I did, as opposed to using the "New issue" button) there is no selection of templates.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org