You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by chiyang10000 <gi...@git.apache.org> on 2017/12/05 08:27:02 UTC
[GitHub] incubator-hawq pull request #1320: HAWQ-1564. Add Pluggable Storage Dependen...
GitHub user chiyang10000 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1320
HAWQ-1564. Add Pluggable Storage Dependent Information
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chiyang10000/incubator-hawq HAWQ-1564
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1320.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1320
----
commit eecd4caee128baaef4ae37e0a3c120d3579c98f6
Author: Chiyang Wan <ch...@gmail.com>
Date: 2017-12-05T01:57:02Z
HAWQ-1564. Add Pluggable Storage Dependent Information
----
---
[GitHub] incubator-hawq pull request #1320: HAWQ-1564. Add Pluggable Storage Dependen...
Posted by chiyang10000 <gi...@git.apache.org>.
Github user chiyang10000 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1320#discussion_r155136178
--- Diff: src/include/access/relscan.h ---
@@ -127,6 +132,16 @@ typedef struct FileScanDescData
/* custom data formatter */
FormatterData *fs_formatter;
+ /* formatter type and name */
--- End diff --
I have updated my code due to your comments. thx!
---
[GitHub] incubator-hawq pull request #1320: HAWQ-1564. Add Pluggable Storage Dependen...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1320#discussion_r155131380
--- Diff: src/include/access/relscan.h ---
@@ -127,6 +132,16 @@ typedef struct FileScanDescData
/* custom data formatter */
FormatterData *fs_formatter;
+ /* formatter type and name */
--- End diff --
the indent of declaration need to be consistent with existing code
---
[GitHub] incubator-hawq pull request #1320: HAWQ-1564. Add Pluggable Storage Dependen...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1320#discussion_r155131160
--- Diff: src/backend/access/external/url.c ---
@@ -2318,7 +2321,24 @@ InvokeExtProtocol(void *ptr,
extprotocol->prot_scanquals = file->u.custom.scanquals;
extprotocol->prot_last_call = last_call;
extprotocol->desc = desc;
+ extprotocol->splits = NULL;
+ if (*psplits != NULL) {
--- End diff --
check psplits itself to make sure it is not null here
---
[GitHub] incubator-hawq pull request #1320: HAWQ-1564. Add Pluggable Storage Dependen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1320
---