You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/12/29 14:18:56 UTC
[GitHub] [rocketmq] fantow opened a new issue #2530: [Remoting] There is a redundant waiting for response when request send fail in sync mode.
fantow opened a new issue #2530:
URL: https://github.com/apache/rocketmq/issues/2530
**BUG REPORT**
1. Please describe the issue you observed:
**There is a redundant wait for response when request send fail in sync mode.
In my opinion,we should just throw a sendFail Exception rather than waiting until overtime because when request send fail.
Obviously,it can not get it's response.**
U can find this code in org.apache.rocketmq.remoting.netty.NettyRemotingAbstract#invokeSyncImpl.
If this is an issue,may I submit a PR to fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #2530: [Remoting] There is a redundant waiting for response when request send fail in sync mode.
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #2530:
URL: https://github.com/apache/rocketmq/issues/2530#issuecomment-779256722
If the send fails the operationComplete method will be executed immediately and the call to responseFuture.putResponse will execute countdown, so the following responseFuture.waitResponse will be returned immediately without waiting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhiboo commented on issue #2530: [Remoting] There is a redundant waiting for response when request send fail in sync mode.
Posted by GitBox <gi...@apache.org>.
lizhiboo commented on issue #2530:
URL: https://github.com/apache/rocketmq/issues/2530#issuecomment-766299077
> **BUG REPORT**
>
> 1. Please describe the issue you observed:
> **There is a redundant wait for response when request send fail in sync mode.
> In my opinion,we should just throw a sendFail Exception rather than waiting until overtime because when request send fail.
> Obviously,it can not get it's response.**
>
> U can find this code in org.apache.rocketmq.remoting.netty.NettyRemotingAbstract#invokeSyncImpl.
>
> 
>
> If this is an issue,may I submit a PR to fix it?
can u describe the concrete version and list the code ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] fantow commented on issue #2530: [Remoting] There is a redundant waiting for response when request send fail in sync mode.
Posted by GitBox <gi...@apache.org>.
fantow commented on issue #2530:
URL: https://github.com/apache/rocketmq/issues/2530#issuecomment-767402449
> > **BUG REPORT**
> >
> > 1. Please describe the issue you observed:
> > **There is a redundant wait for response when request send fail in sync mode.
> > In my opinion,we should just throw a sendFail Exception rather than waiting until overtime because when request send fail.
> > Obviously,it can not get it's response.**
> >
> > U can find this code in org.apache.rocketmq.remoting.netty.NettyRemotingAbstract#invokeSyncImpl.
> > 
> > If this is an issue,may I submit a PR to fix it?
>
> can u describe the concrete version and list the code ?
U can find this code in the latest version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #2530: [Remoting] There is a redundant waiting for response when request send fail in sync mode.
Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #2530:
URL: https://github.com/apache/rocketmq/issues/2530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #2530: [Remoting] There is a redundant waiting for response when request send fail in sync mode.
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #2530:
URL: https://github.com/apache/rocketmq/issues/2530#issuecomment-779259436
I will close the Issue first, but please feel free to reopen it if you have any other issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org