You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/25 16:27:13 UTC

[GitHub] [beam] ibzib commented on a change in pull request #15388: [BEAM-12796] Fixes BQ Storage client import errors in BQ Sources

ibzib commented on a change in pull request #15388:
URL: https://github.com/apache/beam/pull/15388#discussion_r695916810



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -332,11 +332,19 @@ def compute_table_name(row):
 try:
   from apache_beam.io.gcp.internal.clients.bigquery import DatasetReference
   from apache_beam.io.gcp.internal.clients.bigquery import TableReference
-  import google.cloud.bigquery_storage_v1 as bq_storage
 except ImportError:
   DatasetReference = None
   TableReference = None
 
+_LOGGER = logging.getLogger(__name__)
+
+try:
+  import google.cloud.bigquery_storage_v1 as bq_storage
+except ImportError:
+  _LOGGER.warning(
+      'ImportError: import google.cloud.bigquery_storage_v1 as bq_storage',

Review comment:
       Why not log the actual ImportError?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org