You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/14 18:54:20 UTC
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #219: [YUNIKORN-2] gang scheduling shim side implementation
codecov[bot] edited a comment on pull request #219:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/219#issuecomment-760395169
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219?src=pr&el=h1) Report
> Merging [#219](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219?src=pr&el=desc) (368300d) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **increase** coverage by `2.29%`.
> The diff coverage is `76.41%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 57.43% 59.73% +2.29%
==========================================
Files 32 35 +3
Lines 2859 3129 +270
==========================================
+ Hits 1642 1869 +227
- Misses 1147 1179 +32
- Partials 70 81 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `53.06% <0.00%> (-7.41%)` | :arrow_down: |
| [pkg/common/events/states.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvc3RhdGVzLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `25.00% <ø> (ø)` | |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `76.74% <59.25%> (-2.31%)` | :arrow_down: |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `77.27% <77.27%> (ø)` | |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `74.40% <82.22%> (+7.42%)` | :arrow_up: |
| [pkg/appmgmt/general/general.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvZ2VuZXJhbC9nZW5lcmFsLmdv) | `59.47% <83.33%> (+2.03%)` | :arrow_up: |
| [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `85.00% <85.00%> (ø)` | |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `63.15% <90.00%> (+1.36%)` | :arrow_up: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `41.08% <100.00%> (+0.13%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219?src=pr&el=footer). Last update [eb888df...368300d](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org