You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2015/08/25 21:42:20 UTC
[GitHub] incubator-streams pull request: resolves Streams 356
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/249
resolves Streams 356
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-356
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit 8b4d83437930a656f471ccaa3db06bad6e45c12b
Author: Steve Blackmon (@steveblackmon) <sb...@apache.org>
Date: 2015-08-24T20:40:59Z
resolves STREAMS-356
commit 93257d0a45bc05b4b43a50bc4d33e9b07212d2f2
Author: Steve Blackmon (@steveblackmon) <sb...@apache.org>
Date: 2015-08-25T16:45:00Z
resolves ambiguous reference compile error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves Streams 356
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/249#discussion_r38779050
--- Diff: streams-core/src/main/java/org/apache/streams/core/StreamsDatum.java ---
@@ -51,10 +51,22 @@ public StreamsDatum(Object document, DateTime timestamp, BigInteger sequenceid)
this(document, null, timestamp, sequenceid);
}
+ public StreamsDatum(Object document, DateTime timestamp, Map<String, Object> metadata) {
+ this(document, null, timestamp, null, metadata);
+ }
+
public StreamsDatum(Object document, String id, DateTime timestamp) {
this(document, id, timestamp, null);
--- End diff --
thanks. fixing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves Streams 356
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/249#issuecomment-135878237
travis failure is attributable to failure to deploy snapshots from jenkins
https://issues.apache.org/jira/browse/BUILDS-88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves Streams 356
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/249#discussion_r38568376
--- Diff: streams-core/src/main/java/org/apache/streams/core/StreamsDatum.java ---
@@ -51,10 +51,22 @@ public StreamsDatum(Object document, DateTime timestamp, BigInteger sequenceid)
this(document, null, timestamp, sequenceid);
}
+ public StreamsDatum(Object document, DateTime timestamp, Map<String, Object> metadata) {
+ this(document, null, timestamp, null, metadata);
+ }
+
public StreamsDatum(Object document, String id, DateTime timestamp) {
this(document, id, timestamp, null);
--- End diff --
If this is calling the constructor on line 66, then passing null for metadata is inconstant with the empty hash in the constructors on 34 and 38.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: resolves Streams 356
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---