You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2023/08/12 18:10:11 UTC
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #33351: Make skip of trigger form in UI if no params are defined configurable
pierrejeambrun commented on code in PR #33351:
URL: https://github.com/apache/airflow/pull/33351#discussion_r1292418080
##########
airflow/config_templates/config.yml:
##########
@@ -1779,6 +1779,15 @@ webserver:
type: string
example: "sha256"
default: "md5"
+ skip_trigger_form_if_no_params:
Review Comment:
```suggestion
show_trigger_form_if_no_params:
```
Will avoid a double negation in the code such as `not cong.getboolean(...)`. A bit easier to read IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org