You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2017/09/20 21:47:11 UTC
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Tianyi Wang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8113
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
IMPALA-5966: Fix the result file location of PlannerTest
The Plannertest result files should be written to
$IMPALA_FE_TEST_LOGS_DIR/PlannerTest, but instead they are written to
$IMPALA_FE_TEST_LOGS_DIR with "PlannerTest" as the prefix of their
filenames. This patch fixes this bug.
Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
---
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
1 file changed, 6 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/8113/1
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8113 )
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-Change-Number: 8113
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 21:31:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#2).
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
IMPALA-5966: Fix the result file location of PlannerTest
The Plannertest result files should be written to
$IMPALA_FE_TEST_LOGS_DIR/PlannerTest, but instead they are written to
$IMPALA_FE_TEST_LOGS_DIR with "PlannerTest" as the prefix of their
filenames. This patch fixes this bug and refactores surrounding code a
little, replacing some Strings with Paths.
Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
---
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
1 file changed, 9 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/8113/2
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8113 )
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-Change-Number: 8113
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 17:28:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8113 )
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
Patch Set 2:
> Did you try it manually and confirm that it works?
I did.
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-Change-Number: 8113
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 17:24:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8113 )
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1251/
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-Change-Number: 8113
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 17:28:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8113 )
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
IMPALA-5966: Fix the result file location of PlannerTest
The Plannertest result files should be written to
$IMPALA_FE_TEST_LOGS_DIR/PlannerTest, but instead they are written to
$IMPALA_FE_TEST_LOGS_DIR with "PlannerTest" as the prefix of their
filenames. This patch fixes this bug and refactores surrounding code a
little, replacing some Strings with Paths.
Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Reviewed-on: http://gerrit.cloudera.org:8080/8113
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
1 file changed, 9 insertions(+), 11 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-Change-Number: 8113
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8113/1/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java:
Line 90: private final String testDir_ = "functional-planner/queries/PlannerTest";
> also do the same for testDir_ while you are here
Done
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8113/1/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java:
Line 90: private final String testDir_ = "functional-planner/queries/PlannerTest";
also do the same for testDir_ while you are here
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8113 )
Change subject: IMPALA-5966: Fix the result file location of PlannerTest
......................................................................
Patch Set 2:
Did you try it manually and confirm that it works?
--
To view, visit http://gerrit.cloudera.org:8080/8113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20005bd0421e1bb9f3eedbb003c97d92a8faf110
Gerrit-Change-Number: 8113
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 16:21:31 +0000
Gerrit-HasComments: No