[GitHub] [airflow] kaxil commented on a diff in pull request #27776: Add deferrable mode to dataflow operators

[GitBox <gi...@apache.org>]

kaxil commented on code in PR #27776:
URL: https://github.com/apache/airflow/pull/27776#discussion_r1054897101


##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -719,6 +691,40 @@ def start_template_dataflow(
         jobs_controller.wait_for_done()
         return response["job"]
 
+    def _update_environment(self, environment: dict | None, variables: dict) -> dict:

Review Comment:
   if `environment` accepts `None`, why not add a default of `None`?
   
   ```suggestion
       def _update_environment(self, variables: dict,  environment: dict | None = None) -> dict:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org