You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/12/21 15:18:20 UTC
Review Request 41606: Ambari Server Unit Test failure on trunk
(org.apache.ambari.server.bootstrap.BootStrapTest.testRun)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41606/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
Bugs: AMBARI-14446
https://issues.apache.org/jira/browse/AMBARI-14446
Repository: ambari
Description
-------
{code}
Stacktrace
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:48)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertFalse(Assert.java:34)
at junit.framework.Assert.assertFalse(Assert.java:41)
at org.apache.ambari.server.bootstrap.BootStrapTest.testRun(BootStrapTest.java:110)
{code}
Diffs
-----
ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java df68ef9
Diff: https://reviews.apache.org/r/41606/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 41606: Ambari Server Unit Test failure on trunk
(org.apache.ambari.server.bootstrap.BootStrapTest.testRun)
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41606/#review111465
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Дек. 21, 2015, 2:18 п.п., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41606/
> -----------------------------------------------------------
>
> (Updated Дек. 21, 2015, 2:18 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
>
>
> Bugs: AMBARI-14446
> https://issues.apache.org/jira/browse/AMBARI-14446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Stacktrace
>
> junit.framework.AssertionFailedError: null
> at junit.framework.Assert.fail(Assert.java:48)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at junit.framework.Assert.assertFalse(Assert.java:34)
> at junit.framework.Assert.assertFalse(Assert.java:41)
> at org.apache.ambari.server.bootstrap.BootStrapTest.testRun(BootStrapTest.java:110)
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java df68ef9
>
> Diff: https://reviews.apache.org/r/41606/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41606: Ambari Server Unit Test failure on trunk
(org.apache.ambari.server.bootstrap.BootStrapTest.testRun)
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Гру. 21, 2015, 2:21 після полудня, Andrew Onischuk wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java, line 111
> > <https://reviews.apache.org/r/41606/diff/1/?file=1173825#file1173825line111>
> >
> > Wondering why don't we use join. To wait for thread. This can break on slow envs like BAO is
1) Because we don't have an instance of bsRunner(thread) in test, and we can't get it. To get it, we should add additional code to existing non test logic.
2) I decided to fix problem in context of logic that we have for now. 5 seconds it's not a critical time for more than 1 hour, for full java tests run.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41606/#review111466
-----------------------------------------------------------
On Гру. 21, 2015, 2:18 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41606/
> -----------------------------------------------------------
>
> (Updated Гру. 21, 2015, 2:18 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
>
>
> Bugs: AMBARI-14446
> https://issues.apache.org/jira/browse/AMBARI-14446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Stacktrace
>
> junit.framework.AssertionFailedError: null
> at junit.framework.Assert.fail(Assert.java:48)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at junit.framework.Assert.assertFalse(Assert.java:34)
> at junit.framework.Assert.assertFalse(Assert.java:41)
> at org.apache.ambari.server.bootstrap.BootStrapTest.testRun(BootStrapTest.java:110)
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java df68ef9
>
> Diff: https://reviews.apache.org/r/41606/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41606: Ambari Server Unit Test failure on trunk
(org.apache.ambari.server.bootstrap.BootStrapTest.testRun)
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41606/#review111466
-----------------------------------------------------------
ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java (line 104)
<https://reviews.apache.org/r/41606/#comment171671>
Wondering why don't we use join. To wait for thread. This can break on slow envs like BAO is
- Andrew Onischuk
On Dec. 21, 2015, 2:18 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41606/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 2:18 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
>
>
> Bugs: AMBARI-14446
> https://issues.apache.org/jira/browse/AMBARI-14446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Stacktrace
>
> junit.framework.AssertionFailedError: null
> at junit.framework.Assert.fail(Assert.java:48)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at junit.framework.Assert.assertFalse(Assert.java:34)
> at junit.framework.Assert.assertFalse(Assert.java:41)
> at org.apache.ambari.server.bootstrap.BootStrapTest.testRun(BootStrapTest.java:110)
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java df68ef9
>
> Diff: https://reviews.apache.org/r/41606/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41606: Ambari Server Unit Test failure on trunk
(org.apache.ambari.server.bootstrap.BootStrapTest.testRun)
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41606/#review111464
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Dec. 21, 2015, 2:18 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41606/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 2:18 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
>
>
> Bugs: AMBARI-14446
> https://issues.apache.org/jira/browse/AMBARI-14446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> {code}
> Stacktrace
>
> junit.framework.AssertionFailedError: null
> at junit.framework.Assert.fail(Assert.java:48)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at junit.framework.Assert.assertFalse(Assert.java:34)
> at junit.framework.Assert.assertFalse(Assert.java:41)
> at org.apache.ambari.server.bootstrap.BootStrapTest.testRun(BootStrapTest.java:110)
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java df68ef9
>
> Diff: https://reviews.apache.org/r/41606/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>