You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/25 17:21:58 UTC
[GitHub] [airflow] dacohen opened a new pull request #6901: [AIRFLOW-6345]
Ensure arguments to ProxyFix are integers
dacohen opened a new pull request #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901
Make sure you have checked _all_ steps below.
### Jira
- [/] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6345
### Description
- [/] Here are some details about my PR, including screenshots of any UI changes:
This fixes a type mismatch between the string value returned by the Airflow configuration module, and the integer expected by Werkzeug.
### Tests
- [/] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Unit tests updated to reflect requirement for integers
### Commits
- [/] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [/] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] danielpoonwj commented on a change in pull request #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
danielpoonwj commented on a change in pull request #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#discussion_r361382404
##########
File path: tests/www/test_app.py
##########
@@ -36,23 +36,23 @@ def test_constructor_no_proxyfix(self):
def test_constructor_proxyfix(self):
app, _ = application.create_app(session=Session, testing=True)
self.assertTrue(isinstance(app.wsgi_app, ProxyFix))
- self.assertEqual(app.wsgi_app.x_for, '1')
- self.assertEqual(app.wsgi_app.x_proto, '1')
- self.assertEqual(app.wsgi_app.x_host, '1')
- self.assertEqual(app.wsgi_app.x_port, '1')
- self.assertEqual(app.wsgi_app.x_prefix, '1')
+ self.assertEqual(app.wsgi_app.x_for, 1)
+ self.assertEqual(app.wsgi_app.x_proto, 1)
+ self.assertEqual(app.wsgi_app.x_host, 1)
+ self.assertEqual(app.wsgi_app.x_port, 1)
+ self.assertEqual(app.wsgi_app.x_prefix, 1)
@conf_vars({('webserver', 'enable_proxy_fix'): 'True',
- ('webserver', 'proxy_fix_x_for'): '3',
- ('webserver', 'proxy_fix_x_proto'): '4',
- ('webserver', 'proxy_fix_x_host'): '5',
- ('webserver', 'proxy_fix_x_port'): '6',
- ('webserver', 'proxy_fix_x_prefix'): '7'})
+ ('webserver', 'proxy_fix_x_for'): 3,
Review comment:
looks like the CI failure is because these values need to be strings - reverting changes for this portion should work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [947fb64...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dacohen commented on a change in pull request #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
dacohen commented on a change in pull request #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#discussion_r361483283
##########
File path: tests/www/test_app.py
##########
@@ -36,23 +36,23 @@ def test_constructor_no_proxyfix(self):
def test_constructor_proxyfix(self):
app, _ = application.create_app(session=Session, testing=True)
self.assertTrue(isinstance(app.wsgi_app, ProxyFix))
- self.assertEqual(app.wsgi_app.x_for, '1')
- self.assertEqual(app.wsgi_app.x_proto, '1')
- self.assertEqual(app.wsgi_app.x_host, '1')
- self.assertEqual(app.wsgi_app.x_port, '1')
- self.assertEqual(app.wsgi_app.x_prefix, '1')
+ self.assertEqual(app.wsgi_app.x_for, 1)
+ self.assertEqual(app.wsgi_app.x_proto, 1)
+ self.assertEqual(app.wsgi_app.x_host, 1)
+ self.assertEqual(app.wsgi_app.x_port, 1)
+ self.assertEqual(app.wsgi_app.x_prefix, 1)
@conf_vars({('webserver', 'enable_proxy_fix'): 'True',
- ('webserver', 'proxy_fix_x_for'): '3',
- ('webserver', 'proxy_fix_x_proto'): '4',
- ('webserver', 'proxy_fix_x_host'): '5',
- ('webserver', 'proxy_fix_x_port'): '6',
- ('webserver', 'proxy_fix_x_prefix'): '7'})
+ ('webserver', 'proxy_fix_x_for'): 3,
Review comment:
This is now fixed, and the CI passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [947fb64...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [947fb64...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0d052dc4707c0d841d8fdc3889e9dc1546c04bba?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [0d052dc...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [947fb64...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [947fb64...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #6901: [AIRFLOW-6345] Ensure
arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6901: [AIRFLOW-6345]
Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [947fb64...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [947fb64...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6901:
[AIRFLOW-6345] Ensure arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-569080256
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=h1) Report
> Merging [#6901](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6901 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 679 679
Lines 38505 38505
=======================================
Hits 32623 32623
Misses 5882 5882
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6901/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.47% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=footer). Last update [947fb64...f3d975c](https://codecov.io/gh/apache/airflow/pull/6901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6901: [AIRFLOW-6345] Ensure
arguments to ProxyFix are integers
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #6901: [AIRFLOW-6345] Ensure arguments to ProxyFix are integers
URL: https://github.com/apache/airflow/pull/6901#issuecomment-568929470
CI Failed
```
FAILED tests/www/test_app.py::TestApp::test_constructor_proxyfix_args - TypeE...
____________________ TestApp.test_constructor_proxyfix_args ____________________
/usr/local/lib/python3.6/contextlib.py:51: in inner
with self._recreate_cm():
/usr/local/lib/python3.6/contextlib.py:81: in __enter__
return next(self.gen)
tests/test_utils/config.py:42: in conf_vars
conf.set(section, key, value)
/usr/local/lib/python3.6/configparser.py:1192: in set
self._validate_value_types(option=option, value=value)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <airflow.configuration.AirflowConfigParser object at 0x7fed7fd8e630>
def _validate_value_types(self, *, section="", option="", value=""):
"""Raises a TypeError for non-string values.
The only legal non-string value if we allow valueless
options is None, so we need to check if the value is a
string if:
- we do not allow valueless options, or
- we allow valueless options but the value is not None
For compatibility reasons this method is not used in classic set()
for RawConfigParsers. It is invoked in every case for mapping protocol
access and in ConfigParser.set().
"""
if not isinstance(section, str):
raise TypeError("section names must be strings")
if not isinstance(option, str):
raise TypeError("option keys must be strings")
if not self._allow_no_value or value:
if not isinstance(value, str):
> raise TypeError("option values must be strings")
E TypeError: option values must be strings
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services