You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2016/01/08 06:50:35 UTC

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

GitHub user d2r opened a pull request:

    https://github.com/apache/storm/pull/995

    [STORM-1430] ui worker checkboxes

    This adds new checkboxes to the Executors tables of the component pages. Selecting these will enable the debugging/profiling actions to be performed on multiple workers while making it much easier to choose workers—especially for topologies with hundreds of workers.
    
    Look at the documentation to see what has changed. This is a little hard to test, because of [STORM-1452](https://issues.apache.org/jira/browse/STORM-1452). As a work-around, manually copy flight.bash to somewhere on the supervisor process's PATH and it should work.
    
    This also cleans up some tooltip placement and removes some extra bindings from core.clj, and I put these in their own commits so it is clearer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/d2r/storm storm-1430-ui-worker-checkboxes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/995.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #995
    
----
commit 181a46dfa561ba863a170efc5b688e5427ee7089
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-08T05:06:03Z

    removes unnecessary bindings

commit a1c3ebbc249e5d35ae59531b424f90b930471378
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-08T05:22:40Z

    corrects tooltip placement

commit 497aa0991b05b1e8296511bbc3aacf0d9a0830ad
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-08T05:26:17Z

    Adds debugging checkboxes and links to exec table

commit c34266924a0bcb7c17bddc0a602580e892153651
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-08T05:27:30Z

    updates profiling docs for action checkboxes & links

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/995


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/995#issuecomment-170060607
  
    The one test failure was netty load test. It looks unrelated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/995#issuecomment-170087408
  
    Oh +1, even without it, but if you aren't going to do it here let me know and I'll file a JIRA to fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/995#discussion_r49221805
  
    --- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
    @@ -1108,12 +1108,8 @@
       (GET "/api/v1/topology/:id/profiling/start/:host-port/:timeout"
            [:as {:keys [servlet-request]} id host-port timeout & m]
            (thrift/with-configured-nimbus-connection nimbus
    --- End diff --
    
    These all seem to be missing `(populate-context! servlet-request)` We need to add it as the first thing in each of the REST requests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/995#issuecomment-170093379
  
    +1 for fixing it as a part of STORM-1452 and +1 for this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/995#issuecomment-170087235
  
    Only one thing with security that looks like a merge error, not related to this, but fixing it here would be trivial. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/995#issuecomment-170089128
  
    > Oh +1, even without it, but if you aren't going to do it here let me know and I'll file a JIRA to fix it.
    
    Good catch. Maybe we should fix this as part of [STORM-1452](https://issues.apache.org/jira/browse/STORM-1452). I made a comment pointing back here on that Jira.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1430] ui worker checkboxes

Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:

    https://github.com/apache/storm/pull/995#issuecomment-170081940
  
    +1. LGTM. It is very helpful to be able to select executor(s) for action while looking at rest of the stats.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---