You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/17 02:30:02 UTC
Review Request 12615: Cloak "state.cluster" message in nav bar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12615/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
"{{state.cluster}}" flashes in the upper right of the nav bar before the template is replaced by Angular. Angular provides the ngCloak directive[1] to hide elements until they are rendered, and this is an appropriate use case. The rest of the page can render fine without waiting for this floating element.
[1] http://docs.angularjs.org/api/ng.directive:ngCloak
Diffs
-----
src/webui/master/static/index.html 0a9c52fd9921f7f69bd78116b7c9b2ee9fbd8b88
Diff: https://reviews.apache.org/r/12615/diff/
Testing
-------
Rendered the homepage to verify "{{state.cluster}}" no longer flashed before being rendered.
Thanks,
Ross Allen
Re: Review Request 12615: Cloak "state.cluster" message in nav bar
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12615/#review23425
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 17, 2013, 12:30 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12615/
> -----------------------------------------------------------
>
> (Updated July 17, 2013, 12:30 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> "{{state.cluster}}" flashes in the upper right of the nav bar before the template is replaced by Angular. Angular provides the ngCloak directive[1] to hide elements until they are rendered, and this is an appropriate use case. The rest of the page can render fine without waiting for this floating element.
>
> [1] http://docs.angularjs.org/api/ng.directive:ngCloak
>
>
> Diffs
> -----
>
> src/webui/master/static/index.html 0a9c52fd9921f7f69bd78116b7c9b2ee9fbd8b88
>
> Diff: https://reviews.apache.org/r/12615/diff/
>
>
> Testing
> -------
>
> Rendered the homepage to verify "{{state.cluster}}" no longer flashed before being rendered.
>
>
> Thanks,
>
> Ross Allen
>
>