You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "kingluo (via GitHub)" <gi...@apache.org> on 2023/04/11 03:05:34 UTC

[GitHub] [apisix] kingluo commented on a diff in pull request #9267: fix: body-transformer should have a smaller priority than proxy-cache

kingluo commented on code in PR #9267:
URL: https://github.com/apache/apisix/pull/9267#discussion_r1162253486


##########
t/plugin/body-transformer.t:
##########
@@ -23,9 +23,28 @@ no_root_location();
 add_block_preprocessor(sub {
     my ($block) = @_;
 
-    if (!$block->request) {
-        $block->set_value("request", "GET /t");
+    my $http_config = $block->http_config // <<_EOC_;
+
+    # for proxy cache

Review Comment:
   We use a memory-only cache handler, so do we need disk zone settings?



##########
t/plugin/body-transformer.t:
##########
@@ -652,3 +671,112 @@ foobar:
             assert(res.status == 200)
         }
     }
+
+
+=== TEST 10: cooperation of cache-proxy plugin

Review Comment:
   typo fix: `cache-proxy` -> `proxy-cache`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org