You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/12 01:22:34 UTC

[GitHub] [helix] jiajunwang commented on pull request #1328: Implement TestBestPossibleExternalViewVerifier

jiajunwang commented on pull request #1328:
URL: https://github.com/apache/helix/pull/1328#issuecomment-691374998


   > This diff is approve, please help to merge into trunk.
   > 
   > > TestBestPossibleExternalViewVerifier would have a default COOL_DOWN period
   > > before verifyByPolling. Due to #526, currently we have randow sleep in the
   > > test before verifyByPolling. We intend to use TestBestPossibeVerifier
   > > instead in our unit test. While keep using BestPossibleExternalViewVerifier
   > > in production code.
   
   @kaisun2000 please update the comment, it has diverged from the code change quite a lot. Please do take care of the final comment message, once it is in, we don't have a way to modify except reverting the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org