Re: [PATCH] Added html output capability to ab.c

[Martin Kraemer <ma...@mch.sni.de>]

On Sat, Jan 30, 1999 at 12:47:48AM -0800, David N. Welton wrote:
> Hello, as this is my first Apache patch, I hope I'm following the
> correct procedures.
> 
> Anyway, I wanted to run the ab benchmarking program as a quick way to
> do some rough guestimates on a module I am writing (mod_dtcl), as
> compared to another module.  I decided that it would be nice to put
> these results in a web page, but didn't really feel like writing a
> Perl script to chop up the output of 'ab', and so I added the
> functionality directly into 'ab'.  It's maybe not the cleanest way of
> doing it, but it's quick and dirty and functions.  I'm willing to
> spend the time to do it a 'better' way if someone wants to give me
> some ideas.

Though I wouldn't want *any* WWW client to use my server as a "benchmarking
server" (possibly pestering other servers and hiding behind my server's
IP address), I think the idea is nice. And, as you propose, it can be
used offline as a HTML page generation tool. Perhaps a way to add
table attributes (border / color) would be nice?

I have had to change the calls to min() and max() to the (already
present) defines ap_min() and ap_max().

And I fixed the copyright date patch which had slipped in:
> - * Copyright (c) 1998-1999 The Apache Group.  All rights reserved.
> + * Copyright (c) 1998 The Apache Group.  All rights reserved.

I just checked in the modified version.

    Martin
-- 
<Ma...@MchP.Siemens.De>      |        Siemens Information and
Phone: +49-89-636-46021               |        Communication  Products
FAX:   +49-89-636-47816               |        81730  Munich,  Germany