You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "TALBIYA-PARVEEN (via GitHub)" <gi...@apache.org> on 2026/04/23 15:41:37 UTC
[PR] Add is_docker_available helper for silent Docker checks [airflow]
TALBIYA-PARVEEN opened a new pull request, #65732:
URL: https://github.com/apache/airflow/pull/65732
What does this PR do?
Adds is_docker_available() to dev/breeze/src/airflow_breeze/utils/docker_command_utils.py.
The existing check_docker_is_running() prints console output and calls sys.exit(1) on failure, making it unsuitable as a silent boolean guard.
The new helper returns True/False without side effects, following the same pattern as is_docker_rootless().
Handles three cases:
* Docker running → True
* Docker installed but not running → False
* Docker not installed → False (via FileNotFoundError)
Was generative AI tooling used to co-author this PR?
* [ ] Yes
Checklist
* No newsfragment needed (internal Breeze utility, not user-facing)
* No docs update needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add is_docker_available helper for silent Docker checks [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #65732:
URL: https://github.com/apache/airflow/pull/65732#issuecomment-4323677697
Why do you need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add is_docker_available helper for silent Docker checks [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #65732: Add is_docker_available helper for silent Docker checks
URL: https://github.com/apache/airflow/pull/65732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add is_docker_available helper for silent Docker checks [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #65732:
URL: https://github.com/apache/airflow/pull/65732#issuecomment-4558240188
@TALBIYA-PARVEEN This draft PR has been inactive for 8 days since the last triage comment and no response from the author. Closing to keep the queue clean.
You are welcome to reopen this PR when you resume work, or to open a new one addressing the issues previously raised. There is no rush — take your time.
---
_Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add is_docker_available helper for silent Docker checks [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #65732:
URL: https://github.com/apache/airflow/pull/65732#issuecomment-4473467068
@TALBIYA-PARVEEN This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
**Issues found:**
- :x: **Pre-commit / static checks**: `CI image checks / Static checks` is failing. Run `prek run --from-ref main --stage pre-commit` locally and fix anything that flags. See the [static-checks docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst).
- :x: **Provider-distribution compat tests**: `Compat 2.11.1:P3.10`, `Compat 3.0.6:P3.10`, `Compat 3.1.8:P3.10`, and `Compat 3.2.1:P3.10` are failing. Typically means the change uses a symbol or API not present in older Airflow core versions; check `airflow>=...` lower bounds and conditional imports in the affected provider(s). See the [provider distributions docs](https://github.com/apache/airflow/blob/main/contributing-docs/12_provider_distributions.rst).
**What to do next:**
- Make static checks pass locally: `prek run --from-ref main --stage pre-commit`.
- Resolve the compat failures by guarding new APIs with version-aware imports or by adjusting the provider's `airflow>=…` lower bound if the change really requires the newer core.
- Mark the PR as "Ready for review" when you're done.
Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
---
_Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org