You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2018/06/24 17:28:50 UTC

[whimsy] branch master updated: Unnecessary now to check for matching prefix

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new da0bcc4  Unnecessary now to check for matching prefix
da0bcc4 is described below

commit da0bcc47ed30f3789d2bef97fbca65b320630f33
Author: Sebb <se...@apache.org>
AuthorDate: Sun Jun 24 18:28:49 2018 +0100

    Unnecessary now to check for matching prefix
    
    It's also risky, as it could match unrelated entries
---
 www/secretary/icla-lint.cgi | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/www/secretary/icla-lint.cgi b/www/secretary/icla-lint.cgi
index d040242..3aa63ce 100755
--- a/www/secretary/icla-lint.cgi
+++ b/www/secretary/icla-lint.cgi
@@ -106,12 +106,6 @@ _html do
         missing = $1.split(',').select {|path| not iclas.include? path}
 
         if not missing.empty?
-          missing = missing.select do |path|
-            not iclas.any? {|icla| icla.start_with? path}
-          end
-        end
-
-        if not missing.empty?
           issue, note = 'error', "missing icla: #{missing.first.inspect}"
         end
       elsif comment =~ /^Treasurer;/ or comment =~ /^President;/