You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2026/09/08 16:38:10 UTC
[PR] KAFKA-21029: [2/2] Remove hamcrest from org.apache.kafka.streams.state.internals package [kafka]
majialoong opened a new pull request, #23406:
URL: https://github.com/apache/kafka/pull/23406
Remove hamcrest from a subset of tests in the `org.apache.kafka.streams.state.internals` package by migrating to JUnit assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-21029: [2/2] Remove hamcrest from org.apache.kafka.streams.state.internals package [kafka]
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov merged PR #23406:
URL: https://github.com/apache/kafka/pull/23406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-21029: [2/2] Remove hamcrest from org.apache.kafka.streams.state.internals package [kafka]
Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on code in PR #23406:
URL: https://github.com/apache/kafka/pull/23406#discussion_r3960197293
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/OffsetCheckpointTest.java:
##########
@@ -96,13 +92,13 @@ public void shouldDeleteExistingCheckpointWhenNoOffsets() throws IOException {
checkpoint.write(offsets);
- assertThat(file.exists(), is(true));
- assertThat(offsets, is(checkpoint.read()));
+ assertTrue(file.exists());
+ assertEquals(offsets, checkpoint.read());
Review Comment:
The `offsets` written to the checkpoint should be the expected value, and `checkpoint.read()` should provide the actual value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org