You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/04 19:23:55 UTC
[GitHub] [airflow] bbovenzi opened a new issue, #28737: Add legend to grid view
bbovenzi opened a new issue, #28737:
URL: https://github.com/apache/airflow/issues/28737
### Description
It would be useful to add a simple legend to the grid view.
- Help a user understand the icons for a manual / backfill / dataset triggered dag runs
- Help a user understand the symbol for tasks/runs with a note
### Use case/motivation
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #28737: Add legend to grid view
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-1375004932
> @bbovenzi is this issue taken? I would like to try my hands here given some more reference material here.
Nope! It's all yours. Feel free to ask any questions here.
We'll probably want to make a new react component and put add it in the main grid view component [here](https://github.com/apache/airflow/blob/main/airflow/www/static/js/dag/grid/index.tsx).
- We'll want to refer to each [RunTypeIcon](https://github.com/apache/airflow/blob/main/airflow/www/static/js/components/RunTypeIcon.tsx)
- And we'll want to explain the [gradient](https://github.com/apache/airflow/blob/main/airflow/www/static/js/utils/index.ts#L128) we use to indicate if there is a note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #28737: Add legend to grid view
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-1375380019
You can refer to the legend row of dag run/task instance statuses. Basically, just a representation of each icon/gradient with a word or two next to it.
We don't need an extra mom package. Just a simple react component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28737: Add legend to grid view
Posted by GitBox <gi...@apache.org>.
amoghrajesh commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-1375095038
Hi, @bbovenzi I am new to Airflow and would likewith to get a few things clarified before starting.
- Do we have some kind of legends in the airflow codebase that i can refer to? Also, are we talking about legend being a small component that gives out some information like in graphs etc or react-legend?(https://www.npmjs.com/package/react-legend)
- I would appreciate it if you could provide me some online reference for the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28737: Add legend to grid view
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-1441615088
@ashb @bbovenzi coming back to this issue after some time. We are trying to add some legend to this page if I am not mistaken:
1. We can add a small legend for type of run
2. A small legend for tasks vs runs? How do I identify them in terms of logos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #28737: Add legend to grid view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-1442003093
1.[Here](https://github.com/apache/airflow/blob/main/airflow/www/static/js/components/RunTypeIcon.tsx) you can see each run type and icon we use
2. No, but we want to also indicate if a task or run has a note. See the logic [here](https://github.com/apache/airflow/blob/main/airflow/www/static/js/dag/grid/dagRuns/Bar.tsx#L115)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28737: Add legend to grid view
Posted by GitBox <gi...@apache.org>.
amoghrajesh commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-1374709754
@bbovenzi is this issue taken? I would like to try my hands here given some more reference material here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28737: Add legend to grid view
Posted by GitBox <gi...@apache.org>.
amoghrajesh commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-1375493182
@bbovenzi a follow-up on which row you meant here? Can you show me where the legend is here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #28737: Add legend to grid view
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-1377097883
@amoghrajesh That is not the Gird view we are talking about -- this one is https://airflow.apache.org/docs/apache-airflow/stable/ui.html#grid-view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org