You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/09/02 01:46:33 UTC
[PR] [WIP][SQL] Split FunctionRegistry initialization into helper methods [spark]
zhengruifeng opened a new pull request, #58463:
URL: https://github.com/apache/spark/pull/58463
### What changes were proposed in this pull request?
This PR splits the built-in expression definitions in `FunctionRegistry` into private helper
methods grouped by their existing logical sections. It also moves the internal expression
registration sequence into a helper method.
The public `expressions` map, its entry order, and the internal registration order are preserved.
### Why are the changes needed?
`FunctionRegistry` defines hundreds of expressions in its object initializer. Code coverage
instrumentation adds enough bytecode for that initializer to exceed the JVM's 64 KB method limit.
Moving the expression construction and internal registrations into helper methods keeps each
generated method below that limit and allows coverage instrumentation to remain enabled.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Validation is pending while this PR is a draft. The coverage-instrumented Catalyst build will be
run and the result added here.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59166][SQL] Split FunctionRegistry initialization into helper methods [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #58463: [SPARK-59166][SQL] Split FunctionRegistry initialization into helper methods
URL: https://github.com/apache/spark/pull/58463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59166][SQL] Split FunctionRegistry initialization into helper methods [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #58463:
URL: https://github.com/apache/spark/pull/58463#issuecomment-5505913775
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/21ff4877970894801d8ee6d3ab5b6ba8d7b9a12d
- merged into branch-4.x https://github.com/apache/spark/commit/ed8b5a4cf526a51e593b2a462cc57e53ea5f5315
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org