You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2021/01/14 07:13:15 UTC

[GitHub] [shiro] bmarwell commented on a change in pull request #279: [SHIRO-802] Pr template

bmarwell commented on a change in pull request #279:
URL: https://github.com/apache/shiro/pull/279#discussion_r557088291



##########
File path: .github/pull_request_template.md
##########
@@ -9,6 +9,7 @@ Following this checklist to help us incorporate your contribution quickly and ea
        is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
+ - [ ] By default the project packages the tests in an artifact. To activate them Run `mvn clean test -Purn-its`.

Review comment:
       typo: `run-its`, not `urn-its`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org