You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/11 05:58:19 UTC
[GitHub] [airflow] vikramkoka opened a new pull request #13005: Added database upgrade information to upgrade doc
vikramkoka opened a new pull request #13005:
URL: https://github.com/apache/airflow/pull/13005
Added information about db upgrade sample time to the
database upgrade section.
closes: #12769
@kaxil @potiuk
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13005: Added database upgrade information to upgrade doc
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13005:
URL: https://github.com/apache/airflow/pull/13005#discussion_r540827452
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -508,6 +508,9 @@ At this point, just follow the standard Airflow version upgrade process:
The database upgrade may take a while depending on the number of DAGs in the database and the volume of history
stored in the database for task history, xcom variables, etc.
+ In our testing, we saw that performing the Airflow database upgrade from Airflow 1.10.14 to Airflow 2.0
+ took between two to three minutes on an Airflow database on PostgreSQL with around 35,000 task instances and
+ 500 DAGs.
Review comment:
Should we add a note like "However, this time may depend on your infrastructure and network latencies"? Just to avoid benchmarking. But that's just idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #13005: Added database upgrade information to upgrade doc
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #13005:
URL: https://github.com/apache/airflow/pull/13005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13005: Added database upgrade information to upgrade doc
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13005:
URL: https://github.com/apache/airflow/pull/13005#issuecomment-743288356
Fail is fixed in master already (`asctime` spelling error)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13005: Added database upgrade information to upgrade doc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13005:
URL: https://github.com/apache/airflow/pull/13005#issuecomment-743089490
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org