You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/17 08:55:54 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #4280: Fix #4279 to import PlatformTransactionManager completely in camel-qu…
zhfeng opened a new pull request, #4280:
URL: https://github.com/apache/camel-quarkus/pull/4280
…arkus-jpa
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng closed pull request #4280: Fix #4279 to import PlatformTransactionManager completely in camel-qu…
Posted by GitBox <gi...@apache.org>.
zhfeng closed pull request #4280: Fix #4279 to import PlatformTransactionManager completely in camel-qu…
URL: https://github.com/apache/camel-quarkus/pull/4280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4280: Fix #4279 to import PlatformTransactionManager completely in camel-qu…
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4280:
URL: https://github.com/apache/camel-quarkus/pull/4280#issuecomment-1322861802
It suppressed by https://github.com/apache/camel-quarkus/pull/4286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4280: Fix #4279 to import PlatformTransactionManager completely in camel-qu…
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4280:
URL: https://github.com/apache/camel-quarkus/pull/4280#issuecomment-1318416195
We should probably open an issue to rethink how we're handling the removal of Spring from the JPA extension.
With the current way, I wonder if we're creating a potential maintenance headache? E.g if the Spring APIs change in the future, do we need to update these placeholder classes and interfaces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4280: Fix #4279 to import PlatformTransactionManager completely in camel-qu…
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4280:
URL: https://github.com/apache/camel-quarkus/pull/4280#issuecomment-1318437116
Yeah, it is exactly what I'm worrying about. In case of APIs changes, I think we need to update these classes and interfaces otherwise `camel-jms` or othere components which depend on `spring-tx` will be failing when combining with `camel-jpa`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4280: Fix #4279 to import PlatformTransactionManager completely in camel-qu…
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4280:
URL: https://github.com/apache/camel-quarkus/pull/4280#issuecomment-1322926661
@jamesnetherton I've reopened https://github.com/apache/camel-quarkus/issues/4084 to think about removing spring from JPA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4280: Fix #4279 to import PlatformTransactionManager completely in camel-qu…
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4280:
URL: https://github.com/apache/camel-quarkus/pull/4280#issuecomment-1321654824
Wondering whether an alternative 'fix' might be to revert the Spring removal from the JPA extension? That would give us some more time to think through a better solution for the future. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org