You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Remilito <gi...@git.apache.org> on 2017/02/20 11:17:49 UTC
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3
GitHub user Remilito opened a pull request:
https://github.com/apache/zeppelin/pull/2040
[ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3
### What is this PR for?
* bump nvd3 to 1.8.5 (and remove depecrated functions)
* display percentage in pie chart
NB: visualization-scatterchart.js's tooltip content generator has been updated to stop using depecrated tooltip property and use tooltip.contentGenerator instead. However I have commented the code as I think nvd3 scatterchart's default tooltip is far more elegant, open to discussion.
### What type of PR is it?
Improvement
### Todos
* [ ] -
### What is the Jira issue?
* <https://issues.apache.org/jira/browse/ZEPPELIN-1588>
* <https://issues.apache.org/jira/browse/ZEPPELIN-1891>
### How should this be tested?
Visual testing of the builtin visualization.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1891
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2040.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2040
----
commit 1f9aecc1adc0daa395b84f2e5f4ee1fa10860ba3
Author: Remilito <re...@gmail.com>
Date: 2017-02-20T10:22:22Z
[ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3
nvd3 bumped to 1.8.5
benefits from default piechart display which includes pct
replacing deprecated nvd3 calls
scatterchart tooltip is adapted but commented as nvd3 default one seems
more elegant.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito closed the pull request at:
https://github.com/apache/zeppelin/pull/2040
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito closed the pull request at:
https://github.com/apache/zeppelin/pull/2040
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
Posted by Remilito <gi...@git.apache.org>.
GitHub user Remilito reopened a pull request:
https://github.com/apache/zeppelin/pull/2040
[ZEPPELIN-1588]: bumping nvd3
### What is this PR for?
* bump nvd3 to 1.8.5 (and remove depecrated functions)
* display percentage in pie chart [solve [ZEPPELIN-1891]]
NB: visualization-scatterchart.js's tooltip content generator has been updated to stop using depecrated tooltip property and use tooltip.contentGenerator instead. However I have commented the code as I think nvd3 scatterchart's default tooltip is far more elegant, open to discussion.
### What type of PR is it?
Improvement
### Todos
* [ ] -
### What is the Jira issue?
* <https://issues.apache.org/jira/browse/ZEPPELIN-1588>
* <https://issues.apache.org/jira/browse/ZEPPELIN-1891>
### How should this be tested?
Visual testing of the builtin visualization.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1891
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2040.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2040
----
commit 1f9aecc1adc0daa395b84f2e5f4ee1fa10860ba3
Author: Remilito <re...@gmail.com>
Date: 2017-02-20T10:22:22Z
[ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3
nvd3 bumped to 1.8.5
benefits from default piechart display which includes pct
replacing deprecated nvd3 calls
scatterchart tooltip is adapted but commented as nvd3 default one seems
more elegant.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
Posted by Remilito <gi...@git.apache.org>.
GitHub user Remilito reopened a pull request:
https://github.com/apache/zeppelin/pull/2040
[ZEPPELIN-1588]: bumping nvd3
### What is this PR for?
* bump nvd3 to 1.8.5 (and remove depecrated functions)
* display percentage in pie chart [solve [ZEPPELIN-1891]]
NB: visualization-scatterchart.js's tooltip content generator has been updated to stop using depecrated tooltip property and use tooltip.contentGenerator instead. However I have commented the code as I think nvd3 scatterchart's default tooltip is far more elegant, open to discussion.
### What type of PR is it?
Improvement
### Todos
* [ ] -
### What is the Jira issue?
* <https://issues.apache.org/jira/browse/ZEPPELIN-1588>
* <https://issues.apache.org/jira/browse/ZEPPELIN-1891>
### How should this be tested?
Visual testing of the builtin visualization.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1891
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2040.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2040
----
commit 1f9aecc1adc0daa395b84f2e5f4ee1fa10860ba3
Author: Remilito <re...@gmail.com>
Date: 2017-02-20T10:22:22Z
[ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3
nvd3 bumped to 1.8.5
benefits from default piechart display which includes pct
replacing deprecated nvd3 calls
scatterchart tooltip is adapted but commented as nvd3 default one seems
more elegant.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito closed the pull request at:
https://github.com/apache/zeppelin/pull/2040
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---