You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2001/10/07 06:54:53 UTC
cvs commit: httpd-2.0/server config.c
wrowe 01/10/06 21:54:53
Modified: server config.c
Log:
Great badness - not a good idea to return OK when you don't modify the
resulting value, even if it's NULL.
Revision Changes Path
1.136 +2 -3 httpd-2.0/server/config.c
Index: config.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/config.c,v
retrieving revision 1.135
retrieving revision 1.136
diff -u -r1.135 -r1.136
--- config.c 2001/09/21 06:23:29 1.135
+++ config.c 2001/10/07 04:54:53 1.136
@@ -1475,9 +1475,8 @@
/* firstly, search cache */
for (cache = r->htaccess; cache != NULL; cache = cache->next)
if (cache->override == override && strcmp(cache->dir, d) == 0) {
- if (cache->htaccess != NULL)
- *result = cache->htaccess;
- return OK;
+ *result = cache->htaccess;
+ return OK;
}
parms = default_parms;