[GitHub] [airflow] VijayantSoni commented on a change in pull request #8701: Adding ElastiCache Hook for creating, describing and deleting replication groups

[GitBox <gi...@apache.org>]

VijayantSoni commented on a change in pull request #8701:
URL: https://github.com/apache/airflow/pull/8701#discussion_r470948436



##########
File path: tests/providers/amazon/aws/hooks/test_elasticache_replication_group.py
##########
@@ -0,0 +1,357 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from unittest import TestCase
+from unittest.mock import Mock
+
+from airflow.exceptions import AirflowException
+from airflow.providers.amazon.aws.hooks.elasticache_replication_group import ElastiCacheReplicationGroupHook
+
+
+class TestElastiCacheHook(TestCase):
+    """
+    Test ElastiCacheHook
+    """
+    REPLICATION_GROUP_ID = "test-elasticache-hook"
+
+    REPLICATION_GROUP_CONFIG = {
+        'ReplicationGroupId': REPLICATION_GROUP_ID,
+        'ReplicationGroupDescription': REPLICATION_GROUP_ID,
+        'AutomaticFailoverEnabled': False,
+        'NumCacheClusters': 1,
+        'CacheNodeType': 'cache.m5.large',
+        'Engine': 'redis',
+        'EngineVersion': '5.0.4',
+        'CacheParameterGroupName': 'default.redis5.0'
+    }
+
+    VALID_STATES = frozenset({
+        'creating', 'available', 'modifying', 'deleting', 'create - failed', 'snapshotting'
+    })
+
+    # Track calls to describe when deleting replication group
+    # First call will return status as `available` and we will initiate delete
+    # Second call with return status as `deleting`
+    # Subsequent call will raise ReplicationGroupNotFoundFault exception
+    describe_call_count_for_delete = 0
+
+    def setUp(self):
+        self.hook = ElastiCacheReplicationGroupHook()
+        setattr(self.hook, 'conn', Mock())

Review comment:
       It gives following IDE warning after this change:
   ```
   Property 'conn' cannot be set
   Inspection info: This inspection checks that properties are accessed correctly: read-only not set, write-only not read, non-deletable not deleted
   ```
   Added suppression for the statement as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org