[GitHub] [beam] lostluck commented on pull request #12061: [BEAM-4634] Add options to allow BigQuery StandardSQL queries.

[GitBox <gi...@apache.org>]

lostluck commented on pull request #12061:
URL: https://github.com/apache/beam/pull/12061#issuecomment-653175129


   I'm fine with it either way for the reasons Robert (Bradshaw) describes.
   Given that standard is the default for the actual go bigquery API,
   defaulting to legacy would be confusing.
   
   The documentation for the Query method should make which dialog it's using
   unambiguous.
   
   On Thu, Jul 2, 2020, 11:50 AM Robert Bradshaw <no...@github.com>
   wrote:
   
   > (1) is not (yet) a concern for Go, but good (if unfortunate) point about
   > (2). Something that could mitigate this is to make it required.
   >
   > On Thu, Jul 2, 2020 at 11:25 AM Brian Michalski <no...@github.com>
   > wrote:
   >
   > > I'm very new to Beam so don't have strong thoughts here, but two things
   > > jump out:
   > >
   > > 1. It's a breaking change.
   > > 2. LegacySQL appears to be the default for Python and Java.
   > >
   > > I don't know enough about the project to understand if there are too many
   > > users for 1 to be feasible (my gut sayz no) or if consistency with other
   > > language SDKs 2 is goal or non-goal.
   > >
   > > —
   > > You are receiving this because you commented.
   > > Reply to this email directly, view it on GitHub
   > > <https://github.com/apache/beam/pull/12061#issuecomment-653157515>, or
   > > unsubscribe
   > > <
   > https://github.com/notifications/unsubscribe-auth/AADWVALZNPX55M6FWLNO3ZLRZTGKBANCNFSM4OFISS3A
   > >
   > > .
   > >
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/12061#issuecomment-653167957>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ADKDOFONHGA7VPPDOZWCJDDRZTJGDANCNFSM4OFISS3A>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org