[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #497: SCB-1321 clean up the code of alpha fsm

[GitBox <gi...@apache.org>]

WillemJiang commented on a change in pull request #497: SCB-1321 clean up the code of alpha fsm
URL: https://github.com/apache/servicecomb-pack/pull/497#discussion_r302843555
 
 

 ##########
 File path: alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/sink/SagaActorEventSender.java
 ##########
 @@ -57,6 +57,7 @@ public void send(BaseEvent event) {
       } else {
         ActorSelection actorSelection = system
             .actorSelection("/user/" + event.getGlobalTxId());
+        //TODO We should leverage the async API that actor provides to send out the message
 
 Review comment:
   I think it should be fine, even we send it message one by one with block API, we cannot generate the event order. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services