You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2020/06/05 04:43:00 UTC
[jira] [Resolved] (YUNIKORN-174) Fix SI constant change from
YUNIKORN-135
[ https://issues.apache.org/jira/browse/YUNIKORN-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wilfred Spiegelenburg resolved YUNIKORN-174.
--------------------------------------------
Fix Version/s: 0.9
Resolution: Fixed
The build of the scheduler interface builds the constants now in the same way as the proto file is build. The generated go file is syntax checked and the build fails when the generated file is not compilable go.
Documentation has been updated to describe how to add constants.
> Fix SI constant change from YUNIKORN-135
> ----------------------------------------
>
> Key: YUNIKORN-174
> URL: https://issues.apache.org/jira/browse/YUNIKORN-174
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: scheduler-interface
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 0.9
>
>
> The build of the SI does not clean up correctly and leaves a file behind even if there are no changes (typo in Makefile)
> Multiple k8shim only constants are part of the spec which should not be in the SI. They are not shared between the k8shim and other shims or the core:
> * SparkLabelAppID
> * SparkLabelRole
> * SparkLabelRoleDriver
> * LabelApp
> * LabelApplicationID
> * LabelQueueName
> And we have no default resource types in the product. The core does not use them in the production code. They are only used in tests and we should remove them from tests also to highlight the fact that the core is resource type agnostic:
> * memory
> * vcore
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org