You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/14 03:08:36 UTC
[GitHub] [skywalking] zhangrm opened a new issue, #10278: [Feature] Upgrade Armeria plugin from 0.98 to 1.21
zhangrm opened a new issue, #10278:
URL: https://github.com/apache/skywalking/issues/10278
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The latest version supported by the apm-sdk-plugin of Skywalking is 0.98. Upgrade the apm-sdk-plugin to armeria-1.21.x.
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1382652173
The plugin is designed for specific versions. Basically, when we face incompatible new version, we should create a new plugin for newer versions, rather than bumping up version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1435473674
Are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhangrm commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by GitBox <gi...@apache.org>.
zhangrm commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1387543816
In addition, I want to move these two original modules (armeria-0.84.x-plugin 、 armeria-0.85.x-plugin) to the apm-armeria-plugins module:
<img width="527" alt="image" src="https://user-images.githubusercontent.com/6973089/213265289-a71f2edf-fc87-499b-914a-112116d7ff83.png">
Please give suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1396250764
I think this is not an issue about changing the folder structure. You are better to submit a pull request to add `apm-armeria-plugins` and move the existing two into it, then send another pull request for the new feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhangrm commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by GitBox <gi...@apache.org>.
zhangrm commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1396373400
That's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhangrm commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by "zhangrm (via GitHub)" <gi...@apache.org>.
zhangrm commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1435832810
Yes, I will submit it this weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhangrm commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by GitBox <gi...@apache.org>.
zhangrm commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1387527444
For maven module management under the apm-sdk-plugin directory, I have the following ideas:
1. SDK main module naming format: apm - ${sdk_name} - plugins, where ${sdk_name} is the real name of the sdk, for example: apm-armeria-plugins
2. The naming format of the sub-module under the main module of the SDK: apm - ${sdk_name} - ${version} - plugins, where ${sdk_name} is the real name of the sdk, and ${version} is the adaptive version of the SDK, for example: apm-armeria-0.99.x-plugin
3. The directory name of Maven module is consistent with<artifactId>and<name>in pom.xml.
To sum up, take "armeria" as an example to show the structure of maven module as shown below:
<img width="494" alt="image" src="https://user-images.githubusercontent.com/6973089/213262732-f1efb56d-2a9a-4ac6-8bfe-afdbf66680d0.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1445361939
@zhangrm New feature has been merged. Please follow up the discussion, and move the existing two plugins into the new created folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhangrm commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by "zhangrm (via GitHub)" <gi...@apache.org>.
zhangrm commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1445379676
This issue has been resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhangrm closed issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by "zhangrm (via GitHub)" <gi...@apache.org>.
zhangrm closed issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
URL: https://github.com/apache/skywalking/issues/10278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1382652705
https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/java-plugin-development-guide/#implement-plugin
Witness class and methods could be used to help plugin identifying versions.
> Set up witnessClasses and/or witnessMethods if the instrumentation has to be activated in specific versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] zhangrm commented on issue #10278: [Feature] Upgrade Armeria apm-sdk-plugin from 0.98.x to 1.21.x
Posted by GitBox <gi...@apache.org>.
zhangrm commented on issue #10278:
URL: https://github.com/apache/skywalking/issues/10278#issuecomment-1382653571
OK，I'm sorry I'm not accurate, I mean by creating a new version plugin to adapt to the new version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org