You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/16 01:50:04 UTC

[jira] [Commented] (METRON-953) Complete migration away from incubator-metron to metron for links and docs

    [ https://issues.apache.org/jira/browse/METRON-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011614#comment-16011614 ] 

ASF GitHub Bot commented on METRON-953:
---------------------------------------

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/590

    METRON-953: Complete migration away from incubator-metron to metron for links and docs

    ## Contributor Comments
    Moving "incubator-metron" to "metron" everywhere other than the current-book directory.  Now that infra is setup everywhere, all links should work with just metron.  In addition, references to the incubator-metron directory are changed to metron (because a clean clone should result in a metron dir now).
    
    At this point, it should only appear in the current-book.  If any of these should survive, let me know.
    
    I still need to run up full dev to validate, but I've opened the links manually and had them resolve.
    
    To validate, make sure there aren't any incubator-metron instances leftover.  Ensure everything still builds and that the site-book looks good (other than anything derived from current-book).  Make sure the various links aren't broken. One Zeppelin dashboard (pcap) is effected by this, and to validate on full dev requires setting up per https://github.com/apache/metron/pull/559.
    
    Any other validation needs are welcome.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron github_travis

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/590.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #590
    
----
commit e7c9a408b39f1555559f097551363e94a80ab905
Author: justinjleet <ju...@gmail.com>
Date:   2017-05-14T23:31:52Z

    Changing the various github links and such

commit d9045423ae57b74f6e09d87ea988467393b05b05
Author: justinjleet <ju...@gmail.com>
Date:   2017-05-15T14:23:20Z

    adding more stuff

----


> Complete migration away from incubator-metron to metron for links and docs
> --------------------------------------------------------------------------
>
>                 Key: METRON-953
>                 URL: https://issues.apache.org/jira/browse/METRON-953
>             Project: Metron
>          Issue Type: Task
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Minor
>
> A lot of docs still reference incubator-metron and the github incubator-metron and apache incubator-metron, etc.  They should be changed to just metron now that infra is in place.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)