You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Nathan Mittler (JIRA)" <ji...@apache.org> on 2006/06/07 19:24:51 UTC

[jira] Created: (AMQ-739) STOMP transport handles JMS type improperly

STOMP transport handles JMS type improperly
-------------------------------------------

         Key: AMQ-739
         URL: https://issues.apache.org/activemq/browse/AMQ-739
     Project: ActiveMQ
        Type: Bug

  Components: Transport  
 Environment: sending from STOMP to JMS
    Reporter: Nathan Mittler
    Priority: Minor


Sending a text message from a stomp client with a content-length results in a bytes message on JMS.  Suggest doing the following ...

1) The stomp transport should always add the content-length header to out-going messages, regardless of content-type or whether or not a content-length was provided on the incoming message.
2) The stomp transport should handle in-coming messages with a content-type header, and should pass that through.
3) If a message comes in without a content-length or a content-type, it should just be assumed a TextMessage.  This way we can use the terminating null character as the delimiter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AMQ-739) STOMP transport handles JMS type improperly

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-739?page=comments#action_36437 ] 

Nathan Mittler commented on AMQ-739:
------------------------------------

clients can use bytes and text messages so long as they follow AMQ's scheme for making the distinction: if content-length is specified, it's a bytes message, otherwise it's text.

So I don't think any action needs to be taken on this issue other than updating AMQ's stomp page to make it clear how to make the distinction between bytes and text using the stomp protocol.

> STOMP transport handles JMS type improperly
> -------------------------------------------
>
>          Key: AMQ-739
>          URL: https://issues.apache.org/activemq/browse/AMQ-739
>      Project: ActiveMQ
>         Type: Bug

>   Components: Transport
>     Versions: 4.0.1, 4.0
>  Environment: sending from STOMP to JMS
>     Reporter: Nathan Mittler
>     Assignee: Nathan Mittler
>     Priority: Minor
>      Fix For: 4.1

>
> Original Estimate: 1 week
>         Remaining: 1 week
>
> Sending a text message from a stomp client with a content-length results in a bytes message on JMS.  Suggest doing the following ...
> 1) The stomp transport should always add the content-length header to out-going messages, regardless of content-type or whether or not a content-length was provided on the incoming message.
> 2) The stomp transport should handle in-coming messages with a content-type header, and should pass that through.
> 3) If a message comes in without a content-length or a content-type, it should just be assumed a TextMessage.  This way we can use the terminating null character as the delimiter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (AMQ-739) STOMP transport handles JMS type improperly

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-739?page=all ]
     
Nathan Mittler resolved AMQ-739:
--------------------------------

    Fix Version:     (was: 4.1)
     Resolution: Won't Fix

Since ActiveMQ already correctly identifies TextMessages and BytesMessages based on content-length, no action is necessary.

The documenation was updated on the wiki to make it clear how to create Text/Bytes messages from Stomp:  http://www.activemq.org/site/stomp.html

> STOMP transport handles JMS type improperly
> -------------------------------------------
>
>          Key: AMQ-739
>          URL: https://issues.apache.org/activemq/browse/AMQ-739
>      Project: ActiveMQ
>         Type: Bug

>   Components: Transport
>     Versions: 4.0.1, 4.0
>  Environment: sending from STOMP to JMS
>     Reporter: Nathan Mittler
>     Assignee: Nathan Mittler
>     Priority: Minor

>
> Original Estimate: 1 week
>         Remaining: 1 week
>
> Sending a text message from a stomp client with a content-length results in a bytes message on JMS.  Suggest doing the following ...
> 1) The stomp transport should always add the content-length header to out-going messages, regardless of content-type or whether or not a content-length was provided on the incoming message.
> 2) The stomp transport should handle in-coming messages with a content-type header, and should pass that through.
> 3) If a message comes in without a content-length or a content-type, it should just be assumed a TextMessage.  This way we can use the terminating null character as the delimiter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AMQ-739) STOMP transport handles JMS type improperly

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-739?page=comments#action_36315 ] 

Nathan Mittler commented on AMQ-739:
------------------------------------

It isn't possible to reuse the "type" header (JMSType) for the purpose of sending through the information as to what type of message it is (text or bytes).  So this means that we need to add another activemq extension header.   I propose "amq-msg-type".

> STOMP transport handles JMS type improperly
> -------------------------------------------
>
>          Key: AMQ-739
>          URL: https://issues.apache.org/activemq/browse/AMQ-739
>      Project: ActiveMQ
>         Type: Bug

>   Components: Transport
>  Environment: sending from STOMP to JMS
>     Reporter: Nathan Mittler
>     Assignee: Nathan Mittler
>     Priority: Minor
>      Fix For: 4.1

>
> Original Estimate: 1 week
>         Remaining: 1 week
>
> Sending a text message from a stomp client with a content-length results in a bytes message on JMS.  Suggest doing the following ...
> 1) The stomp transport should always add the content-length header to out-going messages, regardless of content-type or whether or not a content-length was provided on the incoming message.
> 2) The stomp transport should handle in-coming messages with a content-type header, and should pass that through.
> 3) If a message comes in without a content-length or a content-type, it should just be assumed a TextMessage.  This way we can use the terminating null character as the delimiter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (AMQ-739) STOMP transport handles JMS type improperly

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-739?page=all ]

Hiram Chirino updated AMQ-739:
------------------------------

    Fix Version: 4.1

Lets tentavly target 4.1 for this feature.

> STOMP transport handles JMS type improperly
> -------------------------------------------
>
>          Key: AMQ-739
>          URL: https://issues.apache.org/activemq/browse/AMQ-739
>      Project: ActiveMQ
>         Type: Bug

>   Components: Transport
>  Environment: sending from STOMP to JMS
>     Reporter: Nathan Mittler
>     Assignee: Nathan Mittler
>     Priority: Minor
>      Fix For: 4.1

>
> Original Estimate: 1 week
>         Remaining: 1 week
>
> Sending a text message from a stomp client with a content-length results in a bytes message on JMS.  Suggest doing the following ...
> 1) The stomp transport should always add the content-length header to out-going messages, regardless of content-type or whether or not a content-length was provided on the incoming message.
> 2) The stomp transport should handle in-coming messages with a content-type header, and should pass that through.
> 3) If a message comes in without a content-length or a content-type, it should just be assumed a TextMessage.  This way we can use the terminating null character as the delimiter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (AMQ-739) STOMP transport handles JMS type improperly

Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-739?page=all ]

Nathan Mittler reassigned AMQ-739:
----------------------------------

    Assign To: Nathan Mittler

> STOMP transport handles JMS type improperly
> -------------------------------------------
>
>          Key: AMQ-739
>          URL: https://issues.apache.org/activemq/browse/AMQ-739
>      Project: ActiveMQ
>         Type: Bug

>   Components: Transport
>  Environment: sending from STOMP to JMS
>     Reporter: Nathan Mittler
>     Assignee: Nathan Mittler
>     Priority: Minor

>
> Original Estimate: 1 week
>         Remaining: 1 week
>
> Sending a text message from a stomp client with a content-length results in a bytes message on JMS.  Suggest doing the following ...
> 1) The stomp transport should always add the content-length header to out-going messages, regardless of content-type or whether or not a content-length was provided on the incoming message.
> 2) The stomp transport should handle in-coming messages with a content-type header, and should pass that through.
> 3) If a message comes in without a content-length or a content-type, it should just be assumed a TextMessage.  This way we can use the terminating null character as the delimiter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (AMQ-739) STOMP transport handles JMS type improperly

Posted by "james strachan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-739?page=all ]

james strachan updated AMQ-739:
-------------------------------

    Version: 4.0.1
             4.0

> STOMP transport handles JMS type improperly
> -------------------------------------------
>
>          Key: AMQ-739
>          URL: https://issues.apache.org/activemq/browse/AMQ-739
>      Project: ActiveMQ
>         Type: Bug

>   Components: Transport
>     Versions: 4.0.1, 4.0
>  Environment: sending from STOMP to JMS
>     Reporter: Nathan Mittler
>     Assignee: Nathan Mittler
>     Priority: Minor
>      Fix For: 4.1

>
> Original Estimate: 1 week
>         Remaining: 1 week
>
> Sending a text message from a stomp client with a content-length results in a bytes message on JMS.  Suggest doing the following ...
> 1) The stomp transport should always add the content-length header to out-going messages, regardless of content-type or whether or not a content-length was provided on the incoming message.
> 2) The stomp transport should handle in-coming messages with a content-type header, and should pass that through.
> 3) If a message comes in without a content-length or a content-type, it should just be assumed a TextMessage.  This way we can use the terminating null character as the delimiter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira