You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 06:56:37 UTC
[GitHub] [airflow] wittfabian opened a new pull request #9031: Add ADDITIONAL_PYTHON_DEPS
wittfabian opened a new pull request #9031:
URL: https://github.com/apache/airflow/pull/9031
Reference: https://github.com/apache/airflow/issues/8604
**Description**
Since we have separate "build" segment for the production image, We will need to add any extra dependencies there rather than on top of the base image if someone wants to add those dependencies.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9031: Add ADDITIONAL_PYTHON_DEPS
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9031:
URL: https://github.com/apache/airflow/pull/9031#issuecomment-634554402
There are a few places - breeze-complete and breeze are the two scripts. You can just search for another flag and do it similarly, or I can add it later after your PRs are merged and cc: you in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9031: Add ADDITIONAL_PYTHON_DEPS
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9031:
URL: https://github.com/apache/airflow/pull/9031#issuecomment-634497097
You can mark it as ready for review to merge it @wittfabian - or you might try to extend Breeze with an option to add --additional-python-deps flag if you are brave enough :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wittfabian commented on pull request #9031: Add ADDITIONAL_PYTHON_DEPS
Posted by GitBox <gi...@apache.org>.
wittfabian commented on pull request #9031:
URL: https://github.com/apache/airflow/pull/9031#issuecomment-634526550
I have not yet worked with Breeze, but I would like to see the result ;)
I am already working on https://github.com/apache/airflow/issues/8866.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9031: Add ADDITIONAL_PYTHON_DEPS
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9031:
URL: https://github.com/apache/airflow/pull/9031#issuecomment-634467318
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wittfabian commented on pull request #9031: Add ADDITIONAL_PYTHON_DEPS
Posted by GitBox <gi...@apache.org>.
wittfabian commented on pull request #9031:
URL: https://github.com/apache/airflow/pull/9031#issuecomment-634552807
@potiuk Must the flag be added here?
https://github.com/apache/airflow/blob/master/breeze#L770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #9031: Add ADDITIONAL_PYTHON_DEPS
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #9031:
URL: https://github.com/apache/airflow/pull/9031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9031: Add ADDITIONAL_PYTHON_DEPS
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9031:
URL: https://github.com/apache/airflow/pull/9031#issuecomment-634554520
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org