You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/18 20:31:19 UTC
[GitHub] [spark] sarutak opened a new pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
sarutak opened a new pull request #31885:
URL: https://github.com/apache/spark/pull/31885
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR fixes an imcompatible behavior introduced by #31754.
The problem is that quoted name parts represented as a string are given to the constructor of `UnresolvedAttribute` which takes single string parameter, `sql` method invocation against the `UnresolvedAttrribute` returns different result than before.
One example is ``` UnresolvedAttribute("`a.b`").sql ```. this returned `a.b` before but it doesn't now.
See [this duscussion](https://github.com/apache/spark/pull/31754/files#r597181927) for more details.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For compatibility.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803290567
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136278/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803467927
Merged to master. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802301708
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136224/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803117168
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802364244
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40806/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r598060665
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -62,7 +62,7 @@ class UnsupportedOperationsSuite extends SparkFunSuite with SQLHelper {
assertNotSupportedInBatchPlan(
"select on streaming source",
- streamRelation.select($"count(*)"),
+ streamRelation.select($"`count(*)`"),
Review comment:
Just a question. Do we need this change after this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31885:
URL: https://github.com/apache/spark/pull/31885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802364244
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40806/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r597436968
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -778,11 +778,11 @@ class ExpressionParserSuite extends AnalysisTest {
test("SPARK-17832 function identifier contains backtick") {
val complexName = FunctionIdentifier("`ba`r", Some("`fo`o"))
- assertEqual(complexName.quotedString, UnresolvedAttribute("`fo`o.`ba`r"))
+ assertEqual(complexName.quotedString, UnresolvedAttribute("```fo``o`.```ba``r`"))
Review comment:
nit: `UnresolvedAttribute(Seq("`fo`o", "`ba`r"))` to make it more obvious
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -778,11 +778,11 @@ class ExpressionParserSuite extends AnalysisTest {
test("SPARK-17832 function identifier contains backtick") {
val complexName = FunctionIdentifier("`ba`r", Some("`fo`o"))
- assertEqual(complexName.quotedString, UnresolvedAttribute("`fo`o.`ba`r"))
+ assertEqual(complexName.quotedString, UnresolvedAttribute("```fo``o`.```ba``r`"))
intercept(complexName.unquotedString, "mismatched input")
// Function identifier contains continuous backticks should be treated correctly.
val complexName2 = FunctionIdentifier("ba``r", Some("fo``o"))
- assertEqual(complexName2.quotedString, UnresolvedAttribute("fo``o.ba``r"))
+ assertEqual(complexName2.quotedString, UnresolvedAttribute("`fo````o`.`ba````r`"))
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803126092
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803256883
**[Test build #136278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136278/testReport)** for PR 31885 at commit [`59b8fc8`](https://github.com/apache/spark/commit/59b8fc84a905f5b174de8b95db8b6a3d1a1d7c6b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802351480
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40806/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803256883
**[Test build #136278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136278/testReport)** for PR 31885 at commit [`59b8fc8`](https://github.com/apache/spark/commit/59b8fc84a905f5b174de8b95db8b6a3d1a1d7c6b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r598068409
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -62,7 +62,7 @@ class UnsupportedOperationsSuite extends SparkFunSuite with SQLHelper {
assertNotSupportedInBatchPlan(
"select on streaming source",
- streamRelation.select($"count(*)"),
+ streamRelation.select($"`count(*)`"),
Review comment:
Yes, this is necessary because `$""` in `catalyst/dsl` invokes `UnresolvedAttribute.apply`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803156410
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136268/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803264811
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803126092
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803084891
**[Test build #136268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136268/testReport)** for PR 31885 at commit [`d05037a`](https://github.com/apache/spark/commit/d05037a453a861d25ad679a15fff0c17d5ed219f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802608511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136245/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802272704
cc: @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802600604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802301708
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136224/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802600604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803156410
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136268/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802608511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136245/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r598070114
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -993,7 +993,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
// scalastyle:off caselocale
Some(ctx.tblName.getText.toLowerCase),
// scalastyle:on caselocale
- ctx.colName.asScala.map(_.getText).map(UnresolvedAttribute.apply).toSeq,
+ ctx.colName.asScala.map(_.getText).map(name => UnresolvedAttribute.quoted(name)).toSeq,
Review comment:
Oops. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803268500
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803290567
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136278/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r598061317
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -993,7 +993,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
// scalastyle:off caselocale
Some(ctx.tblName.getText.toLowerCase),
// scalastyle:on caselocale
- ctx.colName.asScala.map(_.getText).map(UnresolvedAttribute.apply).toSeq,
+ ctx.colName.asScala.map(_.getText).map(name => UnresolvedAttribute.quoted(name)).toSeq,
Review comment:
nit.
```scala
- ctx.colName.asScala.map(_.getText).map(name => UnresolvedAttribute.quoted(name)).toSeq,
+ ctx.colName.asScala.map(_.getText).map(UnresolvedAttribute.quoted).toSeq,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r598067185
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -62,7 +62,7 @@ class UnsupportedOperationsSuite extends SparkFunSuite with SQLHelper {
assertNotSupportedInBatchPlan(
"select on streaming source",
- streamRelation.select($"count(*)"),
+ streamRelation.select($"`count(*)`"),
Review comment:
No. I'll restore here. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803265744
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r598060797
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NamedExpressionSuite.scala
##########
@@ -48,5 +48,8 @@ class NamedExpressionSuite extends SparkFunSuite {
assert(attr11.sql === "`c``d`.`a.b` AS `g.h`.`e.f`")
val attr12 = Alias(attr8, "e`f")(qualifier = "g.h"::Nil)
assert(attr12.sql === "`c``d`.`a.b` AS `g.h`.`e``f`")
+
Review comment:
According to the style at line 27~50, we had better remove this empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803288955
**[Test build #136278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136278/testReport)** for PR 31885 at commit [`59b8fc8`](https://github.com/apache/spark/commit/59b8fc84a905f5b174de8b95db8b6a3d1a1d7c6b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803268500
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-803112288
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802607534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40827/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r597439871
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -778,11 +778,11 @@ class ExpressionParserSuite extends AnalysisTest {
test("SPARK-17832 function identifier contains backtick") {
val complexName = FunctionIdentifier("`ba`r", Some("`fo`o"))
- assertEqual(complexName.quotedString, UnresolvedAttribute("`fo`o.`ba`r"))
+ assertEqual(complexName.quotedString, UnresolvedAttribute("```fo``o`.```ba``r`"))
Review comment:
Thanks. I've done for here and the other place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802607534
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40827/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an imcompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31885:
URL: https://github.com/apache/spark/pull/31885#issuecomment-802334624
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40806/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31885: [SPARK-34636][FOLLOWUP][SQL] Fix an incompatible behavior of UnresolvedAttribute.sql
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31885:
URL: https://github.com/apache/spark/pull/31885#discussion_r598067185
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -62,7 +62,7 @@ class UnsupportedOperationsSuite extends SparkFunSuite with SQLHelper {
assertNotSupportedInBatchPlan(
"select on streaming source",
- streamRelation.select($"count(*)"),
+ streamRelation.select($"`count(*)`"),
Review comment:
No. I'll restore here. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org